Remove 'is-loading' class requirement

assets/js/base/utils/render-frontend.js

@@ -41,9 +41,6 @@ const renderBlockFrontend = ( {
 
 		// Use Array.forEach for IE11 compatibility.
 		Array.prototype.forEach.call( containers, ( el, i ) => {
-			if ( ! el.classList.contains( 'is-loading' ) ) {
-				return;
-			}
 			for ( let j = 0; j < parentSelectorsToSkip.length; j++ ) {
 				if ( el.parentNode.closest( parentSelectorsToSkip[ j ] ) ) {
 					return;

assets/js/blocks/products/all-products/index.js

@@ -5,7 +5,6 @@ import { __ } from '@wordpress/i18n';
 import { InnerBlocks } from '@wordpress/block-editor';
 import { registerBlockType } from '@wordpress/blocks';
 import { Icon, grid } from '@woocommerce/icons';
-import classNames from 'classnames';
 import '@woocommerce/atomic-blocks';
 
 /**
@@ -64,9 +63,9 @@ const blockSettings = {
 		};
 		return (
 			<div
-				className={ classNames(
-					'is-loading',
-					getBlockClassName( 'wc-block-all-products', attributes )
+				className={ getBlockClassName(
+					'wc-block-all-products',
+					attributes
 				) }
 				{ ...data }
 			>
@@ -81,10 +80,10 @@ const blockSettings = {
  */
 registerBlockType( 'woocommerce/all-products', {
 	...blockSettings,
+	/**
+	 * Deprecation rule to handle the previous default rows which was 1 instead of 3.
+	 */
 	deprecated: [
-		/**
-		 * Deprecation rule to handle the previous default rows which was 1 instead of 3.
-		 */
 		{
 			attributes: Object.assign( {}, blockSettings.attributes, {
 				rows: { type: 'number', default: 1 },
@@ -106,33 +105,5 @@ registerBlockType( 'woocommerce/all-products', {
 				);
 			},
 		},
-		/**
-		 * Deprecation rule to handle the block without the 'is-loading' class.
-		 */
-		{
-			attributes: blockSettings.attributes,
-			save( { attributes } ) {
-				const dataAttributes = {};
-				Object.keys( attributes )
-					.sort()
-					.forEach( ( key ) => {
-						dataAttributes[ key ] = attributes[ key ];
-					} );
-				const data = {
-					'data-attributes': JSON.stringify( dataAttributes ),
-				};
-				return (
-					<div
-						className={ getBlockClassName(
-							'wc-block-all-products',
-							attributes
-						) }
-						{ ...data }
-					>
-						<InnerBlocks.Content />
-					</div>
-				);
-			},
-		},
 	],
 } );

assets/js/blocks/reviews/all-reviews/index.js

@@ -12,20 +12,8 @@ import '../editor.scss';
 import Editor from './edit';
 import sharedAttributes from '../attributes';
 import save from '../save.js';
-import getDeprecatedProperty from '../deprecated.js';
 import { example } from '../example';
 
-const attributes = {
-	...sharedAttributes,
-	/**
-	 * Show the product name.
-	 */
-	showProductName: {
-		type: 'boolean',
-		default: true,
-	},
-};
-
 /**
  * Register and run the "All Reviews" block.
  * This block lists all product reviews.
@@ -52,7 +40,16 @@ registerBlockType( 'woocommerce/all-reviews', {
 			showProductName: true,
 		},
 	},
-	attributes,
+	attributes: {
+		...sharedAttributes,
+		/**
+		 * Show the product name.
+		 */
+		showProductName: {
+			type: 'boolean',
+			default: true,
+		},
+	},
 
 	/**
 	 * Renders and manages the block.
@@ -67,6 +64,4 @@ registerBlockType( 'woocommerce/all-reviews', {
 	 * Save the props to post content.
 	 */
 	save,
-
-	deprecated: getDeprecatedProperty( attributes ),
 } );

assets/js/blocks/reviews/reviews-by-category/index.js

@@ -11,27 +11,8 @@ import { Icon, review } from '@woocommerce/icons';
 import Editor from './edit';
 import sharedAttributes from '../attributes';
 import save from '../save.js';
-import getDeprecatedProperty from '../deprecated.js';
 import { example } from '../example';
 
-const attributes = {
-	...sharedAttributes,
-	/**
-	 * The ids of the categories to load reviews for.
-	 */
-	categoryIds: {
-		type: 'array',
-		default: [],
-	},
-	/**
-	 * Show the product name.
-	 */
-	showProductName: {
-		type: 'boolean',
-		default: true,
-	},
-};
-
 /**
  * Register and run the "Reviews by category" block.
  */
@@ -58,7 +39,23 @@ registerBlockType( 'woocommerce/reviews-by-category', {
 			showProductName: true,
 		},
 	},
-	attributes,
+	attributes: {
+		...sharedAttributes,
+		/**
+		 * The ids of the categories to load reviews for.
+		 */
+		categoryIds: {
+			type: 'array',
+			default: [],
+		},
+		/**
+		 * Show the product name.
+		 */
+		showProductName: {
+			type: 'boolean',
+			default: true,
+		},
+	},
 
 	/**
 	 * Renders and manages the block.
@@ -73,6 +70,4 @@ registerBlockType( 'woocommerce/reviews-by-category', {
 	 * Save the props to post content.
 	 */
 	save,
-
-	deprecated: getDeprecatedProperty( attributes ),
 } );

assets/js/blocks/reviews/reviews-by-product/index.js

@@ -11,19 +11,8 @@ import '../editor.scss';
 import Editor from './edit';
 import sharedAttributes from '../attributes';
 import save from '../save.js';
-import getDeprecatedProperty from '../deprecated.js';
 import { example } from '../example';
 
-const attributes = {
-	...sharedAttributes,
-	/**
-	 * The id of the product to load reviews for.
-	 */
-	productId: {
-		type: 'number',
-	},
-};
-
 /**
  * Register and run the "Reviews by Product" block.
  */
@@ -49,7 +38,15 @@ registerBlockType( 'woocommerce/reviews-by-product', {
 			productId: 1,
 		},
 	},
-	attributes,
+	attributes: {
+		...sharedAttributes,
+		/**
+		 * The id of the product to load reviews for.
+		 */
+		productId: {
+			type: 'number',
+		},
+	},
 
 	/**
 	 * Renders and manages the block.
@@ -64,6 +61,4 @@ registerBlockType( 'woocommerce/reviews-by-product', {
 	 * Save the props to post content.
 	 */
 	save,
-
-	deprecated: getDeprecatedProperty( attributes ),
 } );