Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Individual products - remove rows slider #59

Closed
jameskoster opened this issue Mar 5, 2018 · 4 comments
Closed

Individual products - remove rows slider #59

jameskoster opened this issue Mar 5, 2018 · 4 comments
Labels
type: bug The issue/PR concerns a confirmed bug.
Milestone

Comments

@jameskoster
Copy link
Member

jameskoster commented Mar 5, 2018

When displaying individual products we know the total number of products the user wants to display. So we only need to present a columns selector - rows should be automatically calculated.

@warrendholmes warrendholmes added the type: bug The issue/PR concerns a confirmed bug. label Mar 7, 2018
@spencerfinnell
Copy link

spencerfinnell commented Mar 14, 2018

Is there a need for Rows when picking products? I picked 4 products and they displayed in the grid. I switched to List View and only 1 was visible because Rows was set to 1 for some reason. If I picked 4 products specifically I think those should always show.

@jameskoster
Copy link
Member Author

Yeah good point. Funny cause that's what I had in the original designs.

Not sure why I opened this issue in the first place :D

@jameskoster
Copy link
Member Author

Ah, I just checked. We're still displaying the rows slider for the individual products scope. We just need to remove that. I'll update the issue.

@jameskoster jameskoster reopened this Mar 15, 2018
@jameskoster jameskoster changed the title Individual products - auto select rows Individual products - remove rows slider Mar 15, 2018
@claudiulodro claudiulodro added this to the 1.0 milestone Mar 22, 2018
@claudiulodro
Copy link
Contributor

See #89

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

No branches or pull requests

4 participants