Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove the word ‘beta’ from the compatibility notice #10019

Merged
merged 2 commits into from Jul 3, 2023

Conversation

nielslange
Copy link
Member

@nielslange nielslange commented Jun 28, 2023

Currently, we’re showing the following message in some places in the Cart and Checkout blocks:

The Cart & Checkout Blocks are a beta feature to optimize for faster checkout. To make sure this feature is right for your store, review the list of compatible extensions

The word beta might prevent merchants from switching to the Cart and the Checkout blocks as it creates the impression that these blocks are not production ready. This PR aims to remove the word beta from the compatibility notice, but keep the rest of the compatibility notice as it is.

Fixes #10009

Screenshots

Before:

Screenshot 2023-06-29 at 15 24 19
After:

Screenshot 2023-06-29 at 15 12 14

Note
After placing the screenshots, the wording had been adjusted from
"The Cart & Checkout Blocks are a feature to [...]"
to
"The Cart & Checkout Blocks are built to [...]".

Testing

User Facing Testing

  1. Create a fresh site.
  2. Create a test page and add the Cart block to it.
  3. Select the Cart block and verify that the notice reads:

"The Cart & Checkout Blocks are built to optimize for faster checkout. To make sure this feature is right for your store, review the list of compatible extensions."

  1. Create a test page and add the Checkout block to it.
  2. Select the Checkout block and verify that the notice reads:

"The Cart & Checkout Blocks are built to optimize for faster checkout. To make sure this feature is right for your store, review the list of compatible extensions."


Note
When testing this on an existing testing site:

  • Make sure that there's no incompatible payment gateway is installed, as the incompatible payment gateway notice prevents the compatibility notice from appearing.
  • Make sure that there's no key called wc-blocks_dismissed_sidebar_compatibility_notices stored in local storage, as this also prevents the compatibility notice from appearing.

WooCommerce Visibility

  • WooCommerce Core
  • Feature plugin
  • Experimental

Changelog

  • Enhancement: Adjust compatibility notice to highlight that the Cart and Checkout blocks are no longer a beta feature.

@nielslange nielslange added type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring. block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Jun 28, 2023
@nielslange nielslange self-assigned this Jun 28, 2023
@woocommercebot woocommercebot requested review from a team and tarhi-saad and removed request for a team June 28, 2023 07:56
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023

The release ZIP for this PR is accessible via:

https://wcblocks.wpcomstaging.com/wp-content/uploads/woocommerce-gutenberg-products-block-10019.zip

Script Dependencies Report

The compare-assets action has detected some changed script dependencies between this branch and trunk. Please review and confirm the following are correct before merging.

Script Handle Added Removed
wc-blocks.js wp-block-editor, wp-blocks, wp-components, wp-compose, wp-core-data, wp-data, wp-edit-site, wp-element, wp-hooks, wp-i18n, wp-plugins, wp-polyfill, wp-primitives ⚠️
active-filters.js wc-blocks-data-store, wc-price-format, wc-settings, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-element, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url ⚠️
all-products.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-blocks-shared-context, wc-blocks-shared-hocs, wc-price-format, wc-settings, wp-a11y, wp-api-fetch, wp-autop, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-escape-html, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-style-engine, wp-url, wp-warning, wp-wordcount ⚠️
all-reviews.js wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives ⚠️
attribute-filter.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-settings, wp-a11y, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-polyfill, wp-primitives, wp-url, wp-warning ⚠️
breadcrumbs.js wc-settings, wp-block-editor, wp-blocks, wp-components, wp-element, wp-i18n, wp-polyfill, wp-primitives ⚠️
cart.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-blocks-shared-context, wc-blocks-shared-hocs, wc-price-format, wc-settings, wp-a11y, wp-api-fetch, wp-autop, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-core-data, wp-data, wp-deprecated, wp-dom, wp-editor, wp-element, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-plugins, wp-polyfill, wp-primitives, wp-style-engine, wp-url, wp-warning, wp-wordcount ⚠️
catalog-sorting.js wp-block-editor, wp-blocks, wp-components, wp-element, wp-i18n, wp-polyfill, wp-primitives ⚠️
checkout.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-price-format, wc-settings, wp-a11y, wp-api-fetch, wp-autop, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-core-data, wp-data, wp-deprecated, wp-dom, wp-editor, wp-element, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-plugins, wp-polyfill, wp-primitives, wp-url, wp-warning, wp-wordcount ⚠️
customer-account.js wc-settings, wp-block-editor, wp-blocks, wp-components, wp-element, wp-i18n, wp-polyfill, wp-primitives ⚠️
featured-category.js react, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-style-engine, wp-url ⚠️
featured-product.js react, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-style-engine, wp-url ⚠️
filter-wrapper.js wp-block-editor, wp-blocks, wp-element, wp-i18n, wp-polyfill, wp-primitives ⚠️
handpicked-products.js react, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
legacy-template.js wc-settings, wp-block-editor, wp-blocks, wp-components, wp-core-data, wp-data, wp-element, wp-i18n, wp-notices, wp-polyfill, wp-primitives ⚠️
mini-cart.js react, wc-price-format, wc-settings, wp-block-editor, wp-blocks, wp-components, wp-data, wp-dom, wp-element, wp-hooks, wp-i18n, wp-polyfill, wp-primitives ⚠️
mini-cart-contents.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-price-format, wc-settings, wp-a11y, wp-autop, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-polyfill, wp-primitives, wp-url, wp-warning, wp-wordcount ⚠️
store-notices.js wp-block-editor, wp-blocks, wp-components, wp-element, wp-i18n, wp-polyfill, wp-primitives ⚠️
price-filter.js react, wc-blocks-data-store, wc-price-format, wc-settings, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-element, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url ⚠️
product-best-sellers.js wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
product-category.js wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
product-categories.js wp-block-editor, wp-blocks, wp-components, wp-data, wp-element, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render ⚠️
product-new.js wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
product-on-sale.js wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
product-query.js wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-element, wp-escape-html, wp-hooks, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-url ⚠️
product-results-count.js wp-block-editor, wp-blocks, wp-element, wp-i18n, wp-polyfill, wp-primitives ⚠️
product-search.js wc-settings, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-element, wp-i18n, wp-polyfill, wp-primitives ⚠️
product-tag.js wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
product-top-rated.js wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
products-by-attribute.js wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
rating-filter.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-settings, wp-a11y, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-polyfill, wp-primitives, wp-url, wp-warning ⚠️
reviews-by-category.js wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url ⚠️
reviews-by-product.js react, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url ⚠️
single-product.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-blocks-shared-context, wc-blocks-shared-hocs, wc-price-format, wc-settings, wp-api-fetch, wp-autop, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-escape-html, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-style-engine, wp-url, wp-warning, wp-wordcount ⚠️
stock-filter.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-settings, wp-a11y, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-polyfill, wp-primitives, wp-url, wp-warning ⚠️
product-collection.js wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-core-data, wp-data, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-url ⚠️
product-template.js wc-settings, wp-block-editor, wp-blocks, wp-components, wp-core-data, wp-data, wp-element, wp-i18n, wp-polyfill ⚠️

This comment was automatically generated by the ./github/compare-assets action.

TypeScript Errors Report

  • Files with errors: 466
  • Total errors: 2239

🎉 🎉 This PR does not introduce new TS errors.

comments-aggregator

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023

Size Change: +7.34 kB (+1%)

Total Size: 1.18 MB

Filename Size Change
build/active-filters-frontend.js 8.64 kB -1 B (0%)
build/active-filters-wrapper-frontend.js 7.58 kB -4 B (0%)
build/active-filters.js 7.48 kB -3 B (0%)
build/all-products-frontend.js 12.3 kB +47 B (0%)
build/all-products.js 41.1 kB +802 B (+2%)
build/all-reviews.js 7.86 kB -5 B (0%)
build/attribute-filter-frontend.js 23 kB -2 B (0%)
build/attribute-filter-wrapper-frontend.js 7.74 kB +3 B (0%)
build/attribute-filter.js 13.3 kB -1 B (0%)
build/breadcrumbs.js 2.13 kB +3 B (0%)
build/cart-blocks/cart-accepted-payment-methods-frontend.js 1.38 kB +2 B (0%)
build/cart-blocks/cart-cross-sells-products--product-price-frontend.js 2.92 kB +1 B (0%)
build/cart-blocks/cart-cross-sells-products-frontend.js 3.83 kB +54 B (+1%)
build/cart-blocks/cart-express-payment--checkout-blocks/express-payment-frontend.js 5.16 kB +1 B (0%)
build/cart-blocks/cart-line-items--mini-cart-contents-block/products-table-frontend.js 5.47 kB -1 B (0%)
build/cart-blocks/cart-order-summary-frontend.js 1.28 kB +2 B (0%)
build/cart-blocks/empty-cart-frontend.js 347 B +1 B (0%)
build/cart-blocks/order-summary-coupon-form-frontend.js 1.63 kB -2 B (0%)
build/cart-blocks/order-summary-discount-frontend.js 2.12 kB +2 B (0%)
build/cart-blocks/order-summary-fee-frontend.js 273 B +1 B (0%)
build/cart-blocks/order-summary-heading-frontend.js 333 B -1 B (0%)
build/cart-blocks/order-summary-shipping-frontend.js 17 kB -32 B (0%)
build/cart-blocks/order-summary-subtotal-frontend.js 274 B +1 B (0%)
build/cart-blocks/proceed-to-checkout-frontend.js 1.44 kB +1 B (0%)
build/cart-frontend.js 29.9 kB -1 B (0%)
build/cart.js 45.4 kB +369 B (+1%)
build/catalog-sorting.js 1.7 kB +2 B (0%)
build/checkout-blocks/fields-frontend.js 332 B +1 B (0%)
build/checkout-blocks/order-summary-cart-items-frontend.js 3.76 kB -2 B (0%)
build/checkout-blocks/order-summary-discount-frontend.js 2.29 kB -2 B (0%)
build/checkout-blocks/order-summary-frontend.js 1.28 kB +2 B (0%)
build/checkout-blocks/order-summary-shipping-frontend.js 17 kB -34 B (0%)
build/checkout-blocks/payment-frontend.js 9.27 kB +1 B (0%)
build/checkout-blocks/pickup-options-frontend.js 4.84 kB -1 B (0%)
build/checkout-blocks/terms-frontend.js 1.56 kB +3 B (0%)
build/checkout-frontend.js 31.8 kB +1 B (0%)
build/checkout.js 47.9 kB +286 B (+1%)
build/customer-account.js 3.19 kB +1 B (0%)
build/featured-product.js 15.3 kB +4 B (0%)
build/filter-wrapper-frontend.js 14.2 kB -7 B (0%)
build/filter-wrapper.js 2.4 kB +1 B (0%)
build/handpicked-products.js 8.05 kB +2 B (0%)
build/legacy-template.js 8.93 kB +2.1 kB (+31%) 🚨
build/mini-cart-component-frontend.js 30.8 kB +70 B (0%)
build/mini-cart-contents-block/cart-button-frontend.js 1.73 kB -1 B (0%)
build/mini-cart-contents-block/checkout-button-frontend.js 1.81 kB -5 B (0%)
build/mini-cart-contents-block/footer-frontend.js 3.83 kB +2 B (0%)
build/mini-cart-contents-block/products-table-frontend.js 588 B +1 B (0%)
build/mini-cart-contents-block/shopping-button-frontend.js 530 B -1 B (0%)
build/mini-cart-contents-block/title-frontend.js 1.89 kB -1 B (0%)
build/mini-cart-contents-block/title-items-counter-frontend.js 1.59 kB -2 B (0%)
build/mini-cart-contents-block/title-label-frontend.js 1.53 kB -3 B (0%)
build/mini-cart-contents.js 18.1 kB +6 B (0%)
build/mini-cart-frontend.js 2.84 kB -6 B (0%)
build/mini-cart.js 5.93 kB -6 B (0%)
build/price-filter-frontend.js 14.7 kB +2 B (0%)
build/product-add-to-cart--product-button--product-image--product-price--product-rating--product-sale-bad--49d3ecb2.js 0 B -272 B (removed) 🏆
build/product-add-to-cart--product-button--product-image--product-rating--product-title.js 0 B -151 B (removed) 🏆
build/product-add-to-cart-frontend.js 6.53 kB +1 B (0%)
build/product-add-to-cart.js 8.83 kB -5 B (0%)
build/product-best-sellers.js 8.36 kB -1 B (0%)
build/product-button--product-image--product-price--product-rating--product-sale-badge--product-sku--prod--5bce0384.js 0 B -954 B (removed) 🏆
build/product-button-frontend.js 2.66 kB -1 B (0%)
build/product-collection.js 12.3 kB +1 B (0%)
build/product-image-frontend.js 2.71 kB +72 B (+3%)
build/product-image.js 4.21 kB +70 B (+2%)
build/product-new.js 8.65 kB -1 B (0%)
build/product-on-sale.js 8.65 kB +1 B (0%)
build/product-price.js 1.68 kB +1 B (0%)
build/product-query.js 11.9 kB +13 B (0%)
build/product-rating-frontend.js 2.35 kB -1 B (0%)
build/product-results-count.js 1.66 kB +3 B (0%)
build/product-search.js 2.63 kB +1 B (0%)
build/product-sku.js 534 B -1 B (0%)
build/product-stock-indicator.js 728 B -2 B (0%)
build/product-tag.js 8.87 kB -139 B (-2%)
build/product-template.js 3.34 kB +1 B (0%)
build/product-title-frontend.js 2.22 kB -2 B (0%)
build/product-title.js 3.66 kB -1 B (0%)
build/product-top-rated.js 8.91 kB -1 B (0%)
build/rating-filter-frontend.js 21.4 kB -29 B (0%)
build/rating-filter-wrapper-frontend.js 6.23 kB -17 B (0%)
build/rating-filter.js 6.92 kB -19 B (0%)
build/reviews-by-category.js 12.1 kB +4 B (0%)
build/reviews-by-product.js 13.3 kB -4 B (0%)
build/single-product.js 11.1 kB +31 B (0%)
build/stock-filter-frontend.js 21.7 kB +3 B (0%)
build/stock-filter-wrapper-frontend.js 6.5 kB +2 B (0%)
build/stock-filter.js 7.67 kB +4 B (0%)
build/store-notices.js 1.69 kB -1 B (0%)
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--decc3dc6-frontend.js 19.4 kB -1 B (0%)
build/vendors--checkout-blocks/shipping-method-frontend.js 12.4 kB +3 B (0%)
build/vendors--price-filter-wrapper-frontend.js 2.2 kB -1 B (0%)
build/vendors--product-add-to-cart-frontend.js 7.25 kB -3 B (0%)
build/wc-blocks-editor-style-rtl.css 6.35 kB +132 B (+2%)
build/wc-blocks-editor-style.css 6.34 kB +131 B (+2%)
build/wc-blocks-style-rtl.css 28 kB +57 B (0%)
build/wc-blocks-style.css 28 kB +58 B (0%)
build/wc-blocks-vendors.js 65.2 kB +110 B (0%)
build/wc-blocks.js 3.74 kB +33 B (+1%)
build/product-add-to-cart--product-button--product-image--product-price--product-rating--product-rating-s--92e2d51d.js 271 B +271 B (new file) 🆕
build/product-add-to-cart--product-button--product-image--product-rating--product-rating-stars--product-title.js 151 B +151 B (new file) 🆕
build/product-button--product-image--product-price--product-rating--product-rating-stars--product-sale-ba--4e6a8b3c.js 952 B +952 B (new file) 🆕
build/product-rating-stars-frontend.js 2.24 kB +2.24 kB (new file) 🆕
build/product-rating-stars.js 939 B +939 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
build/blocks-checkout.js 35.1 kB
build/cart-blocks/cart-cross-sells-frontend.js 253 B
build/cart-blocks/cart-express-payment-frontend.js 720 B
build/cart-blocks/cart-items-frontend.js 301 B
build/cart-blocks/cart-line-items-frontend.js 1.06 kB
build/cart-blocks/cart-totals-frontend.js 307 B
build/cart-blocks/filled-cart-frontend.js 656 B
build/cart-blocks/order-summary-taxes-frontend.js 436 B
build/checkout-blocks/actions-frontend.js 1.88 kB
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.69 kB
build/checkout-blocks/billing-address-frontend.js 1.18 kB
build/checkout-blocks/contact-information-frontend.js 2.04 kB
build/checkout-blocks/express-payment-frontend.js 1.14 kB
build/checkout-blocks/order-note-frontend.js 1.14 kB
build/checkout-blocks/order-summary-coupon-form-frontend.js 1.79 kB
build/checkout-blocks/order-summary-fee-frontend.js 275 B
build/checkout-blocks/order-summary-subtotal-frontend.js 273 B
build/checkout-blocks/order-summary-taxes-frontend.js 435 B
build/checkout-blocks/shipping-address-frontend.js 1.17 kB
build/checkout-blocks/shipping-method-frontend.js 2.63 kB
build/checkout-blocks/shipping-methods-frontend.js 6.41 kB
build/checkout-blocks/totals-frontend.js 361 B
build/featured-category.js 15.1 kB
build/general-style-rtl.css 1.31 kB
build/general-style.css 1.31 kB
build/mini-cart-contents-block/empty-cart-frontend.js 360 B
build/mini-cart-contents-block/filled-cart-frontend.js 267 B
build/mini-cart-contents-block/items-frontend.js 237 B
build/price-filter-wrapper-frontend.js 6.79 kB
build/price-filter.js 8.56 kB
build/price-format.js 1.19 kB
build/product-button.js 3.97 kB
build/product-categories.js 2.72 kB
build/product-category.js 9.37 kB
build/product-price-frontend.js 231 B
build/product-rating.js 1.04 kB
build/product-sale-badge-frontend.js 1.8 kB
build/product-sale-badge.js 665 B
build/product-sku-frontend.js 1.85 kB
build/product-stock-indicator-frontend.js 2.04 kB
build/product-summary-frontend.js 2.26 kB
build/product-summary.js 1.01 kB
build/products-by-attribute.js 9.76 kB
build/reviews-frontend.js 7.17 kB
build/vendors--attribute-filter-wrapper--cart-blocks/order-summary-coupon-form--cart-blocks/order-summary--48e1e4bb-frontend.js 6.83 kB
build/vendors--attribute-filter-wrapper--cart-blocks/order-summary-shipping--checkout-blocks/billing-addr--d9f38f9d-frontend.js 4.2 kB
build/vendors--attribute-filter-wrapper-frontend.js 5.11 kB
build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/cart-line-items--cart-blocks/cart-order--3c5fe802-frontend.js 5.26 kB
build/vendors--cart-blocks/cart-line-items--checkout-blocks/order-summary-cart-items--mini-cart-contents---233ab542-frontend.js 3.57 kB
build/vendors--checkout-blocks/pickup-options--checkout-blocks/shipping-methods-frontend.js 8.25 kB
build/vendors--rating-filter-wrapper-frontend.js 5.11 kB
build/vendors--stock-filter-wrapper-frontend.js 5.11 kB
build/wc-blocks-data.js 22.4 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 934 B
build/wc-blocks-registry.js 3.15 kB
build/wc-blocks-shared-context.js 1.1 kB
build/wc-blocks-shared-hocs.js 1.75 kB
build/wc-blocks-vendors-style-rtl.css 1.96 kB
build/wc-blocks-vendors-style.css 1.96 kB
build/wc-interactivity.js 10.4 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.6 kB
build/wc-shipping-method-pickup-location.js 30.4 kB

compressed-size-action

@ralucaStan
Copy link
Contributor

I think it was beneficial to see the warning with the list of incompatibilities. Was there a decision made that that message should be removed as well?

@nielslange
Copy link
Member Author

I think it was beneficial to see the warning with the list of incompatibilities. Was there a decision made that that message should be removed as well?

Are you referring to the incompatible payment gateway(s) notice, @ralucaStan? That section hasn't been touched. The current logic was as follows:

  • If there's at least one incompatible payment gateway, then show the incompatible payment gateway(s) notice.
  • If there are no incompatible payment gateways, then show the beta label.

Here's a screenshot when viewing this PR and an incompatible payment gateway, in this case WooCommerce PayPal Payments, is active:

Screenshot 2023-06-29 at 12 08 41

@ralucaStan
Copy link
Contributor

I should have been more explicit. I was referring to the notice you removed. I think it would have been beneficial in keeping that but omitting the beta sentence. A rephrase would be needed ofc.
Screenshot 2023-06-29 at 14 12 41

This notice appears on a fresh installation, when not incompatible payment notice is visible

So I propose sticking to the current behaviour, still showing the notice by default when no incompatible payment gateway notice is not showing.

@nielslange
Copy link
Member Author

Thanks for clarifying this, @ralucaStan. I'll adjust the PR accordingly, keep the notice and only remove the word beta.

@nielslange nielslange force-pushed the update/10009-remove-beta-label branch from ac6401e to 2f05977 Compare June 29, 2023 13:10
@nielslange nielslange changed the title Remove beta label Remove the word ‘beta’ from the compatibility notice Jun 29, 2023
Copy link
Contributor

@opr opr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me! I don't see the word beta in the compatibility notice anymore 👀 however, the current copy reads a little bit strange to me (not wrong, just doesn't seem totally natural).

What do you think of the following wording? Feel free to update if you like!

The Cart & Checkout Blocks are built to optimize for faster checkout. To make sure this feature is right for your store, review the list of compatible extensions(opens in a new tab).

@github-actions github-actions bot added this to the 10.6.0 milestone Jul 3, 2023
@nielslange nielslange force-pushed the update/10009-remove-beta-label branch from 11305ea to 988c4e9 Compare July 3, 2023 10:07
@nielslange nielslange merged commit d720e08 into trunk Jul 3, 2023
29 checks passed
@nielslange nielslange deleted the update/10009-remove-beta-label branch July 3, 2023 10:56
@nielslange nielslange mentioned this pull request Jul 6, 2023
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the beta label from the editor and the documentation
3 participants