This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Prevent prefetched Cart payload causing wrong values with cached Mini-Cart block #10029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
type: bug
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/mini-cart/test/block.js
|
|
Size Change: +64 B (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
Aljullu
commented
Jun 29, 2023
| @@ -150,12 +150,10 @@ window.addEventListener( 'load', () => { | |||
| }; | |||
|
|
|||
| const openDrawerWithRefresh = () => { | |||
| miniCartBlock.dataset.isDataOutdated = 'true'; | |||
There was a problem hiding this comment.
This change is not directly related to the rest of the PR, but I found out that isDataOutdated was defined but never read, so it should be safe to remove it.
|
I am still seeing a flash of the old data in some cases. file.movSteps to replicate:
|
Aljullu
force-pushed
the
fix/cart-payload-mini-cart
branch
from
f045b2c
to
f906b81
Compare
roykho
approved these changes
Jun 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9493, we updated the Mini-Cart block to support caching plugins. However, there was still an issue when hovering the button: cached values were displayed for a small period of time. That was caused by the prefetching we did of the
/cart/endpoint, this PR removes that and updates the Mini-Cart block button to always display the correct values.Testing
User Facing Testing
With your admin user:
In a private/incognito window without being logged in:
With your admin user:
WooCommerce Visibility
Changelog