Improved placeholders of translatable string

[claudiosanches]

Some HTML is allowed on translatable strings, WordPress core and WooCommerce includes <a href="%s"> in translatable strings, so becomes less hard to understand, since %s will get joined to another words.

It's possible to find some references in: https://github.com/WordPress/WordPress/search?p=2&q=%3Ca+href%3D%22%251%24s%22+%252%24s%3E&unscoped_q=%3Ca+href%3D%22%251%24s%22+%252%24s%3E

[nerrad]

Some related convo in #889 (which in turn is spawned from convo elsewhere).

I agree that having the tags in the localized string is more translator friendly, if we're going to go this route then we'll either need to use something like this: WordPress/gutenberg#17376 or the calypso solution.

Personally, I'd prefer to see us use strings that would be more familiar to WP translators (i.e. the former), but to use the pull I did we'll need to shim it in this plugin for now because even if the pull is merged it won't be available for a few WP versions.

cc @Aljullu and @mikejolley for your thoughts.

[claudiosanches]

Personally, I'd prefer to see us use strings that would be more familiar to WP translators (i.e. the former),

I'm speaking as one of the translators, I'm a Locale Manager for pt_BR, also I translate WooCommerce to pt_BR, that's why I found those strings.

[Aljullu]

Personally, I'd prefer to see us use strings that would be more familiar to WP translators (i.e. the former), but to use the pull I did we'll need to shim it in this plugin for now because even if the pull is merged it won't be available for a few WP versions.

@nerrad If it's easy, I agree importing your PR from upstream is the best option. That would allow us to update the translation strings now without having to wait until our minimum Gutenberg version updates. I still think we should wait until it's merged into Gutenberg master before importing the code, so we don't need to update it if the PR code changes.

[mikejolley]

See #1736