This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Prevent hooks from being attached to empty content #10453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
added
type: bug
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
danieldudzic
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
👋 The code works as expected!
I'd modify the testing steps in the following way:
- The
functions.phpcode is missing some closing brackets:
add_action( 'woocommerce_before_shop_loop' , function () {
echo 'Hook: woocommerce_before_shop_loop';
});
add_action( 'woocommerce_after_shop_loop' , function () {
echo 'Hook: woocommerce_after_shop_loop';
});
add_action( 'woocommerce_no_products_found' , function () {
echo 'Hook: woocommerce_no_products_found';
});
-
Since the testing requires code changes I'd check the
Do not include in the Testing Notescheckbox. -
I think this qualifies for the
skip-changelogso the changelog is unnecessary.
Since the requested changes only are relating to the PR description I am approving.
|
Thanks @danieldudzic! I applied the changes you mentioned except for
I think in general we communicate fixes in changelog so I'd stick with the changelog 🤔 |
17 tasks
albarin
approved these changes
Aug 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooks were attached also to the blocks that has empty content which is unexpected. As an example the
woocommerce_before_shop_loop_itemandwoocommerce_after_shop_loop_itemwhere rendered "around" the empty Products (Beta) block. This issue fixes the problem.Fixes #10452
Screenshots
Testing
Automated Tests
Issue found during writing E2E test for Compatibility Layer so it will be covered.
User Facing Testing
Expected: Only
woocommerce_no_products_foundshould be firedWooCommerce Visibility
Performance Impact
Changelog