This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Revert #10509 #10513
Merged
Revert #10509 #10513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: bug
woocommercebot
requested review from
a team and
tjcafferkey
and removed request for
a team
|
I will let @opr handle the initial review of this PR since he is the original author, and if needed I will do a follow up test/review of it. |
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
opr
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
I tested this with the following steps:
- Set up new local wp site with
transient.localas the domain, do not use HTTPS - Add item, and visit Cart/Checkout blocks and ensure they load
- Change site name to
newurl.local - Reload site and ensure cart/checkout blocks still load correctly.
- Enable HTTPS in local WP.
- Load site with HTTPS and ensure blocks still load correctly
- Change back to original domain name
transient.localand reload with HTTPS, ensure all load still - Reload
transient.localwithout HTTPS and ensure blocks still load.
I believe this mimics the report, where during the setup of atomic sites it starts briefly without HTTPS and then the switch to HTTPS after it is set up.
gigitux
added a commit
that referenced
this pull request
Aug 9, 2023
* Revert #10509 (#10513) * Revert "Revert "Performance: Cache script data in a transient for production builds" (#10509)" This reverts commit d5f786e. * keep WP 6.2.2 as env to run E2E tests * Empty commit for release pull request * update changelog and testing instructions * bump version to 10.8.2 * update zip link --------- Co-authored-by: Luigi Teschio <gigitux@gmail.com> Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #10509.
For more details and testing instructions check: #10278.