This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix the on sale badge for product blocks
#10550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
dinhtungdu
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +29 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
gigitux
pushed a commit
that referenced
this pull request
Aug 11, 2023
gigitux
added a commit
that referenced
this pull request
Aug 11, 2023
* Create wc-all-block-styles chunk with all the styles for classic themes (#10543) * add testing instructions and changelog * bump version to 10.8.3 * Empty commit for release pull request * add zip link * Fix the `on sale` badge for product blocks (#10550) * Fix the `on sale` badge for product blocks * Fix in the editor * Update changelog and testing instructions * update zip link * fix testing instructions --------- Co-authored-by: Luigi Teschio <gigitux@gmail.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alba Rincón <albarin@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the CSS selector specificity of the sale badge to fix its position.
Testing
Storefronttheme.Products by Attribute,Products by Tag,Products by Category,Handpicked productsandAll productsblocks.Saleback shows on the top-right corner of the image on all of them, in the editor and in the frontend.WooCommerce Visibility
Changelog