This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Enable manual migration of Products to Product Collection #10655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
added
type: enhancement
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
|
Size Change: +1 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
danieldudzic
approved these changes
Aug 18, 2023
roykho
approved these changes
Aug 21, 2023
@roykho, Thanks for review! We allow for revert in case Product Collection doesn't satisfy all of the needs (and we expect early feedback) or if there was something wrong with the migration itself. As an example, we do the same for blockified templates (even though we encourage them, there's still an option to opt-out). |
kmanijak
added a commit
that referenced
this pull request
Aug 25, 2023
* Enable Product Collection as a core feature * Fix: disable product query title and summary variations from inserter in favour of Product Collection ones (#10548) * Limit the scope of Product Query's Product Title and Product Summary * Add missing piece after refactoring * Enable manual migration of Products to Product Collection (#10655) * Refactor block variation registration in product-collection (#10701) This commit refactors the product-collection block's variation registration. Changes: - The `product-summary` and `product-title` variations have been encapsulated within their own respective functions: `registerProductSummaryVariation` and `registerProductTitleVariation`. - Imported and invoked these new functions in the main `index.tsx` of the product-collection block, ensuring the variations are registered. --------- Co-authored-by: Manish Menaria <the.manish.menaria@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR enables manual migration from Products (Beta) to Product Collection blocks. It's on top of #10524, which enables Product Collection as a core feature.
Contributes to #10430
In #10524 we're enabling Product Collection block. Since the migration from Products (Beta) block to Product Collection has been finished, this PR enables additionally manual migration.
It's kept separated to allow testing both scenarios and deciding if we want to proceed with manual migration.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Note: Migration mechanism is not a part of this PR and various scenarios were already tested in the scope of #10268 and #10115. This PR only enables the migration.
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog