This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Store Customization MVP] Add image alts to the ai prompt if available #11101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +11 kB (+1%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
albarin
changed the title
|
Thanks @albarin. I can see the problem we're trying to solve here but I am wondering what other approaches we have considered? I'm not sure what I'm about to suggest is the right way but I was wondering do you think it would be worth moving the ALT text to the dictionary file and using that text to build the prompt & the image alt. In the case of What about if we did the following: {
"name": "Featured Category Focus",
"slug": "woocommerce-blocks/featured-category-focus",
"images_total": 1,
"images_format": "landscape",
"content": {
"titles": [
{
"default": "Announcing our newest collection",
"ai_prompt": "The title of the featured category: {image.0}"
}
],
"image_description": [
"An image of a cosy living room showing contemporary decoration with a fireplace"
]
}
}We could then use the And the alt text: Again I'm not saying my suggestion is the right one, but it feels a little bit more intuitive. What do you think? |
|
After Step 8 I updated the business description to
|
nefeline
reviewed
Oct 9, 2023
There was a problem hiding this comment.
@albarin I think we will have to fine-tune the logic here a bit. Here are the test results on my end:
- On https://advisory-tarsier.jurassic.ninja/ we have the store description set as:
I'm selling merchandise with branding by local breweries. I have a small catalogue of about 10 products. I plan to sell to people who like craft beer. My business is all about beer.
- And in this particular case, since the Verticals API doesn't have any specific images for beers, this was the output received:
- The
"alt"description does exist for all of these images within the verticals API:
Ref: https://public-api.wordpress.com/wpcom/v2/site-verticals/1512/images
But because we are concatenating these with the store description within the PatternsUpdater class, get_patterns_with_content method, the output is still related to the breweries or beers (in this particular example), rather than the images.
As a workaround I would suggest that: for all patterns that display products, if the provided images have an alt description, rely exclusively on those to generate the content rather than a combination between store description + image description to ensure better accuracy. WDYT?
I agree it's not ideal, but when the Verticals API returns an unrelated vertical, even if we only use the image For example, with the current implementation, I used as a description: "A store that sells drugs and medicines" and got this: |
Yeah, you are right; this is a very tricky scenario, especially considering our limitations regarding the number of images available. Let's keep the logic as-is for now and work on additional fine-tuning as part of a separate task so we can spend more time discussing/brainstorming before implementing and unblock this work :) |
danieldudzic
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Uses the
altavailable in some of the Verticals API images to build the prompt so the content makes sense with the image.Also includes a pattern update which was not loading the right content.
Fixes #11084
Why
Since content is AI-generated, we need to avoid some images not matching the image displayed as much as possible.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Create a new JN install with both Jetpack and Woocommerce installed and activated.
Install and activate WooCommerce Blocks from this zip file: woocommerce-gutenberg-products-block.zip.
In your wp-admin, set up the JetPack connection, make sure it's successful.
From your admin screen, click on Tools > Plugin editor:
Select the WooCommerce Blocks plugin and add the following within your woocommerce-blocks/woocommerce-gutenberg-products-block.php file and save:
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog