This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Store Customization > Homepage Template 1: Review layout and spacing in between patterns #11144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
type: enhancement
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
馃帀 馃帀 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.47 MB 鈩癸笍 View Unchanged
|
tjcafferkey
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Looks good other than the issues already described here #11129 (comment) so approving since we have agreed to fix these in a follow-up PR
|
Just noting some visual inconsistencies here:
|
albarin
force-pushed
the
11088/homepage-1-template
branch
from
f7a71fc
to
47ed7b5
Compare
|
@tjcafferkey do you want to have another look?
Good catch! Fixed!
Yes, I saw that and fixed it in one of the other Homepage PRs, I merged them and resolved conflicts and this is not happening anymore.
Fixed by adding a bit of padding on the |
|
Thanks for addressing them @albarin there is one final alignment issue with the triple category pattern but I think we鈥檙e safe to merge and we can address that pattern in a separate PR since it spans multiple templates not just this one. |
This was referenced Oct 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds a group block with padding to the
Product Collection 3 Columns,Featured Category Tripleand theSocial: Follow us on social mediapatterns.Fixes #11088
Why
To adapt to the designs shown on #11088
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Minimal 5-column products rowcorresponds toProduct Collection 5 ColumnsScreenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog