This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Single Product block: Redirect to the cart page after successful addition setting isn't respected #11151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thealexandrelara
changed the title
thealexandrelara
added
block: single product
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.48 MB ℹ️ View Unchanged
|
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
|
@thealexandrelara |
Hey @Marc-pi, I can consistently reproduce this issue, however, it only occurs when the "Add to Cart With Options" block is inside the "Single Product" block. This happens because the default behavior when clicking the "Add to Cart" button is to redirect to the product page. However, since the "Single Product" block can be added to any page, we prevent the redirection from occurring. Unfortunately, we hadn't anticipated the case in which the shopper should be redirected to the cart if the setting is enabled in WooCommerce Settings. |
|
Bumping PR to next release. |
…en-option-is-set-to-true
thealexandrelara
deleted the
fix/10775-redirect-to-cart-not-happening-when-option-is-set-to-true
branch
|
Changed to include in 11.3.0 release. |
roykho
pushed a commit
that referenced
this pull request
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The Single Product block does not respect the setting under WooCommerce > Settings > Products > General > Add to cart behaviour > Check - Redirect to the cart page after successful addition.
Fixes #10775
Why
This PR solves that by checking if the "Redirect to the cart page after successful addition" option was set in the WooCommerce Settings. If that is the case, then we allow the user to be redirected to the cart page after adding the product to the cart.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Test 1: Redirect shopper to the cart page after successful addition when setting is enabled
Test 2: Keep shopper at the same page when setting is disabled
WooCommerce Visibility
Required:
Changelog