This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Gallery block: Add E2E tests to cover Variable Products #11536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -6 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
…products-in-product-gallery-block
thealexandrelara
added
skip-changelog
thealexandrelara
changed the title
…products-in-product-gallery-block
…products-in-product-gallery-block
woocommercebot
requested review from
a team and
samueljseay
and removed request for
a team
roykho
reviewed
Nov 13, 2023
roykho
reviewed
Nov 13, 2023
...cks/product-gallery-large-image/product-gallery-large-image.block_theme.side_effects.spec.ts
Show resolved
Hide resolved
roykho
approved these changes
Nov 14, 2023
thealexandrelara
deleted the
test/11459-add-e2e-tests-to-cover-variable-products-in-product-gallery-block
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds e2e tests that covers the functionality of replacing the Large Image with the selected variable product from the Add to Cart With Options block.
Fixes #11459
Why
When I was working on the issue to add support for variation image updates I decided to handle the e2e tests for that functionality in a later PR, so this is the PR to handle that.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
npm run test:e2e:side-effectson your local machine and make the tests are passing.WooCommerce Visibility
Required: