This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Move TextInput, ValidatedTextInput and ValidationInputError to the @woocommerce/blocks-components package.
#11654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
category: extensibility
woocommercebot
requested review from
a team and
mikejolley
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
packages/components/text-input/test/validated-text-input.tsx
packages/components/text-input/text-input.tsx |
|
Size Change: +4.28 kB (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
mikejolley
suggested changes
Nov 14, 2023
This is because withInstanceId adds it, or it uses the supplied ID. It's not a required prop
|
@mikejolley rebased 👌🏼 |
mikejolley
approved these changes
Nov 14, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Moves
TextInput,ValidatedTextInputandValidationInputErrorto the@woocommerce/blocks-componentspackage.Please note it appears
assets/js/atomic/blocks/product-elements/add-to-cart/product-types/variable/variation-attributes/attribute-select-control.tsxis not actually used anymore as far as I could tell, but the changes were made there anyway to prevent build errors. No testing instructions for this specific path were included.Why
It doesn't make sense to have all of the components spread across three directories.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Internal WC Blocks devs only (do not include this part in the testing notes)
StripeCreditCardfunction to this:truelogged becauseValidationInputErroris a valid element.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog
Dev note
We have moved the
TextInput,ValidatedTextInputandValidationInputErrorcomponents to the@woocommerce/blocks-componentspackage. Previously these were available in@woocommerce/blocks-checkout. Your code will continue to work as we have added aliases to the new location. Despite this, it is recommended that you change your code to import these components from@woocommerce/blocks-componentsas the import from the checkout package will be deprecated in the future.