This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Move Button, StoreNotice and StoreNoticesContainer components into the components package #11766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e components package
woocommercebot
requested review from
a team and
opr
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
packages/components/store-notices-container/index.tsx
packages/components/store-notices-container/snackbar-notices.tsx packages/components/store-notices-container/test/index.tsx |
alexflorisca
force-pushed
the
add/move-button-component
branch
from
861d561
to
1fc4b9d
Compare
|
Size Change: +18.9 kB (+1%) Total Size: 1.56 MB
ℹ️ View Unchanged
|
alexflorisca
added
category: extensibility
opr
suggested changes
Nov 14, 2023
There was a problem hiding this comment.
Hey @alexflorisca couple of comments on this one:
- Can we find existing uses of
Button,StoreNotice, andStoreNoticesContainerand ensure they're being imported from@woocommerce/blocks-components- I know ultimately they will come from the same place regardless, but to make reasoning with the code easier for posterity I think it would be good to update the imports. - The testing steps are a good start, but better would be to find uses of each of these components and figure out how we can test that they're importing correctly. e.g. for the store notice containers I would add something to
core/noticeswith thewc/cartcontext and make sure it shows up on the cart page.
|
Thanks for your comments @opr, I've updated the references to Can you take another look? |
opr
suggested changes
Nov 14, 2023
|
Done. |
opr
approved these changes
Nov 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR moves the Button, StoreNotice and StoreNoticesContainer components into the components package
Fixes #11685
Fixes #11683
Why
We are consolidating all the components that we will export for external use into a
componentspackageTesting Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Internal Developer Testing (do not include in the notes)
let { createErrorNotice } = wp.data.dispatch('core/notices'); createErrorNotice('Hello there', { context: 'wc/cart' });WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog