This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix arguments passed to woocommerce_before_thankyou to mirror core hook
#11862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
type: bug
woocommercebot
requested review from
a team and
nielslange
and removed request for
a team
mikejolley
added
status: blocker
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
tarunvijwani
approved these changes
Nov 21, 2023
14 tasks
opr
pushed a commit
that referenced
this pull request
Nov 21, 2023
opr
pushed a commit
that referenced
this pull request
Nov 21, 2023
opr
pushed a commit
that referenced
this pull request
Nov 21, 2023
wavvves
pushed a commit
that referenced
this pull request
Nov 21, 2023
wavvves
added a commit
that referenced
this pull request
Nov 21, 2023
wavvves
added a commit
that referenced
this pull request
Nov 22, 2023
wavvves
added a commit
that referenced
this pull request
Nov 22, 2023
* Updated changelog and added testing instructions * Updated changelog. * Updated versions. * Updated tested up to * Updated tested up to * Uploaded testing zip * Removed #11287 from testing instructions * Added testing instructions and changelog for #11858 * Updated testing zip * Testing instructions for #11862 and #11860 * Updated testing zip * New testing zip with #11872 🍒 * Updated versions to 11.7.0-dev * Updated composer.lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In core the
woocommerce_before_thankyouhook accepts an order ID:https://github.com/woocommerce/woocommerce/blob/f93f2ad3dd958cefaa9e85890fef919ee168cbe5/plugins/woocommerce/templates/checkout/thankyou.php#L28
In blocks we were passing an order object. It's likely this was missed in testing because the extensions using this hook did not care about this parameter or its type.
Fixes #11851
Why
The hook params should match the legacy hook to avoid type errors.
Testing Instructions
From the issue (requires code):
Hello, this is order XWooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog