This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix an issue that caused the Order by select in Reviews blocks to always be disabled #11918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
type: bug
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/base/components/reviews/review-sort-select/index.tsx
|
|
Size Change: -5 B (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
I don't think these TypeScript errors are specific to this PR. At least, I can see them in |
wavvves
added a commit
that referenced
this pull request
Nov 23, 2023
* Empty commit for release pull request * Add missing woocommerce class (#11919) * Fix an issue that caused the Order by select in Reviews blocks to always be disabled (#11918) * Fix Reviews blocks not being rendered (#11913) * Updated readme.txt and testing instructions * Updated versions * Updated testing zip. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Mike Jolley <mike.jolley@me.com> Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
This was referenced Nov 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11917.
Why
It was not possible to change the value in the Order by select in Reviews blocks. This PR fixes it.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog