This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Reorganise Columns controls and fix undefined problem in Product Collection settings #11937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
added
type: enhancement
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +4.32 kB (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
imanish003
approved these changes
Nov 27, 2023
| hasValue={ () => | ||
| defaultLayout?.shrinkColumns !== shrinkColumns | ||
| defaultLayout?.columns !== columns || | ||
| defaultLayout?.type !== type |
There was a problem hiding this comment.
I don't think the "defaultLayout?.type !== type" condition is necessary. In my view, "defaultLayout?.columns !== columns" should suffice. no?
There was a problem hiding this comment.
Good catch, I applied your suggestion!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improvements to Column controls in Product Collection:
undefinedoption that occurred in Product Collection's Inspector Controls settingsFixes #11561
Fixes #11925
Why
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
undefinedentry, but "Columns" and "Responsive" like in the AFTER image:WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog