This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product gallery - fix “View all” link #11995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +186 B (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
danieldudzic
suggested changes
Nov 30, 2023
|
At request from @roykho I'm taking over this PR. |
…m/woocommerce/woocommerce-blocks into product-gallery/fix/view-all-link
|
@roykho Would you mind reviewing? 🙏 |
roykho
commented
Dec 5, 2023
danieldudzic
approved these changes
Dec 5, 2023
kmanijak
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11988
This PR adds specific styling to the "View All" link and thumbnails count depending on how many thumbnails are displayed.
Why
This is so that shoppers will have a better visual experience and not have the "View All" link out of place or not showing completely.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog