This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 220
Fix decimal ratings not correctly displayed #2507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
focus: components
Work that introduces new or updates existing components.
labels
May 19, 2020
Size Change: -41 B (0%) Total Size: 1.99 MB
ℹ️ View Unchanged
|
nerrad
approved these changes
May 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense 👍 and can confirm visually this fixes things.
However, I noticed that the All Products block renders a rounded down version of the rating for the aria-label (and hidden span) instead of the actual rating.
I think all that needs to happen is the %d
in the following code needs changed to %f
:
Pre-approving because the above change is fairly straightforward, and you can merge after.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: components
Work that introduces new or updates existing components.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split this off from #2428 so it's not blocked by the other changes in that PR.
Screenshots
Before:
After:
How to test the changes in this Pull Request:
Changelog