Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix decimal ratings not correctly displayed #2507

Merged
merged 2 commits into from
May 19, 2020
Merged

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented May 19, 2020

I split this off from #2428 so it's not blocked by the other changes in that PR.

Screenshots

Before:
imatge

After:
imatge

How to test the changes in this Pull Request:

  1. Make sure you have at least one product with an average rating with decimals, ie 4.5.
  2. View the All Products block or a legacy product grid block in the frontend.
  3. Verify the number of stars is correct.

Changelog

Fix star ratings in product grid blocks so they correctly display non-integer ratings.

@Aljullu Aljullu added status: needs review type: bug The issue/PR concerns a confirmed bug. focus: components Work that introduces new or updates existing components. labels May 19, 2020
@Aljullu Aljullu requested a review from a team as a code owner May 19, 2020 09:58
@Aljullu Aljullu self-assigned this May 19, 2020
@Aljullu Aljullu requested review from nerrad and removed request for a team May 19, 2020 09:58
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2020

Size Change: -41 B (0%)

Total Size: 1.99 MB

Filename Size Change
build/style-legacy-rtl.css 5.42 kB -7 B (0%)
build/style-legacy.css 5.43 kB -6 B (0%)
build/style-rtl.css 16.4 kB -12 B (0%)
build/style.css 16.3 kB -16 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 7.23 kB 0 B
build/active-filters.js 7.89 kB 0 B
build/all-products-frontend.js 71.8 kB 0 B
build/all-products.js 19.2 kB 0 B
build/all-reviews-legacy.js 10.3 kB 0 B
build/all-reviews.js 10.6 kB 0 B
build/attribute-filter-frontend.js 16.7 kB 0 B
build/attribute-filter.js 11.5 kB 0 B
build/block-error-boundary-legacy.js 774 B 0 B
build/block-error-boundary.js 775 B 0 B
build/blocks-legacy.js 2.92 kB 0 B
build/blocks.js 2.93 kB 0 B
build/cart-frontend.js 113 kB 0 B
build/cart.js 32.1 kB 0 B
build/checkout-frontend.js 129 kB 0 B
build/checkout.js 37.8 kB 0 B
build/custom-select-control-style-legacy.js 782 B 0 B
build/custom-select-control-style.js 782 B 0 B
build/editor-legacy-rtl.css 12.6 kB 0 B
build/editor-legacy.css 12.6 kB 0 B
build/editor-rtl.css 13.5 kB 0 B
build/editor.css 13.5 kB 0 B
build/featured-category-legacy.js 146 kB 0 B
build/featured-category.js 146 kB 0 B
build/featured-product-legacy.js 9.49 kB 0 B
build/featured-product.js 9.8 kB 0 B
build/handpicked-products-legacy.js 6.88 kB 0 B
build/handpicked-products.js 7.16 kB 0 B
build/panel-style-legacy.js 773 B 0 B
build/panel-style.js 774 B 0 B
build/price-filter-frontend.js 13.8 kB 0 B
build/price-filter.js 9.97 kB 0 B
build/product-best-sellers-legacy.js 6.96 kB 0 B
build/product-best-sellers.js 7.23 kB 0 B
build/product-categories-legacy.js 3.22 kB 0 B
build/product-categories.js 3.21 kB 0 B
build/product-category-legacy.js 7.88 kB 0 B
build/product-category.js 8.14 kB 0 B
build/product-list-style-legacy.js 775 B 0 B
build/product-new-legacy.js 7.12 kB 0 B
build/product-new.js 7.4 kB 0 B
build/product-on-sale-legacy.js 7.49 kB 0 B
build/product-on-sale.js 7.8 kB 0 B
build/product-search-legacy.js 3.12 kB 0 B
build/product-search.js 3.36 kB 0 B
build/product-tag-legacy.js 6.07 kB 0 B
build/product-tag.js 6.33 kB 0 B
build/product-top-rated-legacy.js 7.09 kB 0 B
build/product-top-rated.js 7.37 kB 0 B
build/products-by-attribute-legacy.js 7.85 kB 0 B
build/products-by-attribute.js 8.12 kB 0 B
build/reviews-by-category-legacy.js 12.3 kB 0 B
build/reviews-by-category.js 12.7 kB 0 B
build/reviews-by-product-legacy.js 13.8 kB 0 B
build/reviews-by-product.js 14.2 kB 0 B
build/reviews-frontend-legacy.js 7.99 kB 0 B
build/reviews-frontend.js 8.81 kB 0 B
build/snackbar-notice-style-legacy.js 778 B 0 B
build/snackbar-notice-style.js 779 B 0 B
build/spinner-style-legacy.js 775 B 0 B
build/spinner-style.js 771 B 0 B
build/vendors-legacy.js 376 kB 0 B
build/vendors-style-legacy-rtl.css 1.65 kB 0 B
build/vendors-style-legacy.css 1.65 kB 0 B
build/vendors-style-legacy.js 105 B 0 B
build/vendors-style-rtl.css 1.65 kB 0 B
build/vendors-style.css 1.65 kB 0 B
build/vendors-style.js 105 B 0 B
build/vendors.js 473 kB 0 B
build/wc-blocks-data.js 7.08 kB 0 B
build/wc-blocks-middleware.js 931 B 0 B
build/wc-blocks-registry.js 1.79 kB 0 B
build/wc-payment-method-cheque.js 794 B 0 B
build/wc-payment-method-paypal.js 830 B 0 B
build/wc-payment-method-stripe.js 11.9 kB 0 B
build/wc-settings.js 2.14 kB 0 B

compressed-size-action

Copy link
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense 👍 and can confirm visually this fixes things.

However, I noticed that the All Products block renders a rounded down version of the rating for the aria-label (and hidden span) instead of the actual rating.

I think all that needs to happen is the %d in the following code needs changed to %f:

https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/e4c7636bda2288d1b318ef2314f3caa2e9e50b13/assets/js/atomic/components/product/rating/index.js#L21-L24

Pre-approving because the above change is fairly straightforward, and you can merge after.

@Aljullu
Copy link
Contributor Author

Aljullu commented May 19, 2020

I missed that, good catch @nerrad! Fixed in 42577c3. I updated the string of the Reviews blocks as well, even though their ratings will be integers, this way they share the same translate string.

@Aljullu Aljullu merged commit 82ad134 into master May 19, 2020
@Aljullu Aljullu deleted the fix/decimal-ratings branch May 19, 2020 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: components Work that introduces new or updates existing components. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants