This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Use IE11 friendly code for Dashicon component replacement. #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -81 B (0%) Total Size: 1.57 MB
ℹ️ View Unchanged
|
nerrad
added
the
status: blocker
senadir
approved these changes
Jun 12, 2020
Aljullu
added
the
release: cherry-pick
Aljullu
pushed a commit
that referenced
this pull request
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2703
In #2664 I implemented some code that would swap out the
@woocommerce/components/Dashiconcomponent with a patched fix to reduce our bundle sizes. However, I didn't realize in the process this broke things for IE11 (any frontend client side code importing from@wordpress/componentsdirectly - All Products, Filter Blocks, Cart and Checkout etc).When the
NormalModuleReplacementPluginis used in webpack, the code replacing modules is not transpiled through babel (at least from what I can see). Ideally, we'd figure out how to fix that (and I did take a bit of time to try unsuccessfully) but the simpler fix for now is to just use IE11 friendly code in the script.@Aljullu, ordinarily I wouldn't consider this patch release worthy and would just wait until our next scheduled release, but because the 2.7 branch is going in WC core and 2.8.0 would be past the code freeze date, I think it's better to get this into 2.7.1 so there are no regressions for users of the All Products or Filter blocks on IE11 (even though I think the IE11 experience is super poor!).
To test
This affects All Products, Filter Blocks and Cart and Checkout blocks.
There also should be no significant change in bundlesize (which the GitHub action should report on in this pull).