Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Don't show saving badge if the value is negative #2955

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Don't show saving badge if the value is negative #2955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/js/base/components/cart-checkout/product-price/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import './style.scss';

const ProductPrice = ( { className, currency, regularValue, value } ) => {
const isDiscounted =
Number.isFinite( regularValue ) && regularValue !== value;
Number.isFinite( regularValue ) && regularValue > value;

if ( isDiscounted ) {
return (
Expand Down
2 changes: 1 addition & 1 deletion assets/js/base/components/cart-checkout/product-sale-badge/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import ProductBadge from '../product-badge';
* @return {*} The component.
*/
const ProductSaleBadge = ( { currency, saleAmount } ) => {
if ( ! saleAmount ) {
if ( ! saleAmount || saleAmount <= 0 ) {
return null;
}
return (
Expand Down