This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 220
Add stories to Cart & Checkout totals components #3533
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
focus: components
Work that introduces new or updates existing components.
skip-changelog
PRs that you don't want to appear in the changelog.
labels
Dec 9, 2020
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
Aljullu
force-pushed
the
add/totals-stories
branch
from
December 10, 2020 12:06
0970044
to
c6d77d3
Compare
budzanowski
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, and very clean.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Dec 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: components
Work that introduces new or updates existing components.
skip-changelog
PRs that you don't want to appear in the changelog.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
/assets/js/cart-checkout/totals/
which didn't have one yet./storybook/__mocks__/
.@woocommerce/knobs
alias only available in stories that allows loading knobs that are shared across stories (for now, onlycurrencyKnob
). They are stored in/storybook/knobs/
.Screenshots
How to test the changes in this Pull Request:
TotalsFees
story to be visible.npm run storybook
.@base-components/cart-checkout/totals
and verify they look fine.