This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Check if Cart and Checkout are registered before removing payment methods #4056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods so it won't break Elementor
senadir
added
type: bug
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
nerrad
approved these changes
Apr 13, 2021
senadir
added a commit
that referenced
this pull request
Apr 13, 2021
…hods so it won't break Elementor (#4056)
senadir
added a commit
that referenced
this pull request
Apr 13, 2021
…hods so it won't break Elementor (#4056)
senadir
added a commit
that referenced
this pull request
Apr 13, 2021
…hods so it won't break Elementor (#4056)
senadir
added a commit
that referenced
this pull request
Apr 18, 2021
* Check if Cart and Checkout are registered before removing payment methods so it won't break Elementor (#4056) * Empty commit for release pull request * update versions and add testing file * add download file * Bumping version strings to new version. Co-authored-by: Seghir Nadir <nadir.seghir@gmail.com> Co-authored-by: github-actions <github-actions@github.com>
senadir
added a commit
that referenced
this pull request
Apr 19, 2021
* Check if Cart and Checkout are registered before removing payment methods so it won't break Elementor (#4056) * generating changeset for pull request * generating changeset for pull request * update version * add testing instrcutions * update release.md file Co-authored-by: Seghir Nadir <nadir.seghir@gmail.com> Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes woocommerce/woocommerce#29656
Elementor empties
$wp_scriptsand$wp_styleswhen rendering its editor (which is very dangerous), this breaks our integrations which must run afterwp_enqueue_scriptsand at the beginning ofwp_print_scripts.In this PR, I check if our scripts are still registered before validating payment methods dependencies.
This might have caused a regression with #3920 so more testing should happen using that PR steps.
Testing steps
Regression testing.
Changelog