This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove the ToggleButtonControl in favor of ToggleGroupControl #5967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2.14 kB (0%) Total Size: 861 kB
ℹ️ View Unchanged
|
Script Dependencies ReportThe
This comment was automatically generated by the |
|
Thanks for working on this! LGTM! Are we migrating to experimental components, are we sure that it is safe? @Aljullu If we agree that it is safe, the thing to do is fix ESLint errors and after that, we can merge this PR 🥳 |
Aljullu
added
focus: components
Aljullu
reviewed
Mar 3, 2022
There was a problem hiding this comment.
LGTM as well, good job @danieldudzic!
Are we migrating to experimental components, are we sure that it is safe? @Aljullu
That's a good point, thanks for raising it. I do think that in general we should avoid using experimental features in WC core. However, in this specific case, I think we can do an exception given that it seems a low-risk change and we can revert back if needed.
However, one thing that we should make sure to test is whether this works with WP 5.7, which is the oldest version supported by WC core. (Currently, it's set to 5.6, but I think that needs to be updated)
Just found that there is a PR already prepared to update it: woocommerce/woocommerce#32013 🙂 |
Script Dependencies ReportThe
This comment was automatically generated by the |
Script Dependencies ReportThe
This comment was automatically generated by the |
|
Thanks for updating the PR! It seems that there are other eslint errors. Could you check? If you want, you can try locally with: |
Script Dependencies ReportThe
This comment was automatically generated by the |
gigitux
approved these changes
Mar 10, 2022
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
@danieldudzic is anything blocking this from being merged? |
tarhi-saad
added a commit
that referenced
this pull request
Apr 13, 2022
Add screenshots to the #5967 testing notes
tarhi-saad
added a commit
that referenced
this pull request
Apr 14, 2022
* Empty commit for release pull request * Add Changelog to readme.txt * Update WC tested and required versions * Add testing notes * Register missing C&C inner blocks and update fallback template for older C& C versions (#6195) * Register missing C & C inner blocks and update fallback template for older C & C versions This will fix the issues with missing order summary inner blocks: Coupons (both in C & C blocks) and the Cart header. The issue was happening because, for example, for Cart the coupons were registred on the on frontend, but it just wasn't forced in the attributes. Because it also wasn't added to the PHP fallback layout, the render function didn't include it. For the Checkout block the coupons inner block wasn't registered at all. * Revert changes to Checkout.php, we don't need to test for inner blocks * Revert "Revert changes to Checkout.php, we don't need to test for inner blocks" This reverts commit fc39535. * Fix the returned template for older Checkout block iterations * Fix Cart and Checkout templates to accommodate the Summary order inner blocks * Hide coupon form div from inner blocks if coubons are not enabled * Fix checkout coupon tests in checkout They have been written for logged in user * Fix Order Summary Heading inner block's default text * Update comments with better wording * Revert "Hide coupon form div from inner blocks if coubons are not enabled" This reverts commit ab09021. (cherry picked from commit 40180ae) * Update the zip file link * Update testing instructions * Remove experimental build related PR from testing notes * Fix/order summary sidebar css (#6231) * Add box sizing to Totals item * Add some unit tests for Order summary blocks * Fix Proceed to checkout button size (cherry picked from commit 669aee7) * Update the WC required/tested versions * Mini Cart Contents: Use block pattern to make the empty cart message translatable (#6248) * try: use block pattern to make empty cart message translatable * Update src/BlockTypes/MiniCart.php Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> * rename function Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: Luigi <gigitux@gmail.com> (cherry picked from commit cfe73f1) * Update the release's ZIP file * Update testing notes In #6065, for Cart only Order Summary Heading & Coupon form can be removed, and for Checkout only the Coupon form. * Update the testing notes Remove #5870 testing notes because they can't be tested as a user * Update Testing notes Add screenshots to the #5967 testing notes * Remove #6166 testing instructions We reverted this PR * Revert (#6166) (#6253) Revert "Prevent Featured Product block from breaking when product is out of stock + hidden from catalog (#6166)" This reverts commit 3c0e0af (cherry picked from commit 908526e) * Bumping version strings to new version. Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Saad Tarhi <saad.trh@gmail.com> Co-authored-by: Raluca Stan <ralucastn@gmail.com> Co-authored-by: Luigi Teschio <gigitux@gmail.com> Co-authored-by: Tung Du <dinhtungdu@gmail.com>
4 tasks
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
ToggleButtonControlProduct Blocks component in favor of the coreToggleGroupControl.Fixes #5873
Screenshots
Manual Testing
How to test the changes in this Pull Request:
User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Automated Tests