This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix: Customizer fatal error for bundled woocommerce-blocks package #6317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhtungdu
added
status: needs review
type: bug
|
Size Change: 0 B Total Size: 869 kB ℹ️ View Unchanged
|
tjcafferkey
approved these changes
Apr 26, 2022
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Closed
tarunvijwani
pushed a commit
that referenced
this pull request
Apr 26, 2022
tjcafferkey
pushed a commit
that referenced
this pull request
Apr 27, 2022
tjcafferkey
added a commit
that referenced
this pull request
Apr 27, 2022
* Empty commit for release pull request * Fix: Customizer fatal error for bundled woocommerce-blocks package (#6317) * Add 7.4.3 changelog to readme.txt * Release 7.4.3 testing instructions * Bumping version strings to new version. Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Tung Du <dinhtungdu@gmail.com> Co-authored-by: tjcafferkey <tjcafferkey@gmail.com>
This was referenced Jul 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6314
This PR fixes the fatal error in Customizer when using Woocommerce Blocks bundled in WC Core. This is a hotfix and should be revisited later.
At the time the Customizer is loading, the
wp-content/plugins/woocommerce/packages/woocommerce-blocks/woocommerce-gutenberg-products-block.phpisn't loaded first, which causes the fatal error. This doesn't happen for the WooCommerce Blocks plugin.Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
wp-content/plugins/woocommerce/packages/woocommerce-blocks/src/BlockTypes/MiniCart.php.User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Changelog