This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix: Attribute Filters: allow choosing between single/multiple selection #6620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
albarin
and removed request for
a team
dinhtungdu
added
status: needs review
type: enhancement
|
Requesting one more review from @Aljullu because this PR is based on his suggestion. |
|
Size Change: +111 B (0%) Total Size: 875 kB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Looks great! I tested it with the All Products block and PHP templates and everything seems to be working fine.
Not introduced in this PR, but one suggestion: when the selection mode is Single and display style List, could we replace the checkboxes with radio inputs? I think it's better for accessibility and also a better UI. (No need to do it as part of this PR, it can be done as a follow-up)
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
@Aljullu I thought about this too and experimented with the |
dinhtungdu
changed the title
Ah, good point. I didn't think about this. LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1311
This PR:
AND.single.Savecomponent to avoid block mismatch issues for existing Attribute Filter blocks.Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
Attempt block recoverybutton for that block.Allow selecting multiple options?set to Multiple by default.Single. See theQuery Typesetting disappear.Multiple. Set display style toDropdownand query type toAND.WooCommerce Visibility
Performance Impact
N/A
Changelog