This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Include Cart and Checkout Blocks when included in WC Core #6805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
senadir
reviewed
Aug 1, 2022
Comment on lines
26
to
39
| // This code is being kept in case we add a feature-plugin-only block in future. It will be easy to reinstate. | ||
| // /** | ||
| // * Registers a new feature plugin block provided a unique name and an object | ||
| // * defining its behavior. Once registered, the block is made available as an | ||
| // * option to any editor interface where blocks are implemented. | ||
| // */ | ||
| // export const registerFeaturePluginBlockType = ( | ||
| // blockNameOrMetadata: string | BlockConfiguration, | ||
| // settings: Record< string, unknown > | ||
| // ): Block | undefined => { | ||
| // if ( WC_BLOCKS_PHASE > 1 ) { | ||
| // return registerBlockType( blockNameOrMetadata, settings ); | ||
| // } | ||
| // }; |
There was a problem hiding this comment.
Are you commenting this out because it's not used anymore?
There was a problem hiding this comment.
Yes, I chose to do this instead of deletion because it will be easier to reinstate this if required in future. Easier than finding the PR that removed it I mean.
There was a problem hiding this comment.
I’m on the camp of leaving it intact. It will get treeshaken id not used so it’s not hurting anyone, better than someone using it out of memory just so it doesn’t work for them because it’s commented out. X is undefined are hard to track sometimes.
senadir
reviewed
Aug 1, 2022
Comment on lines
+137
to
+145
| // phpcs:disable Squiz.PHP.CommentedOutCode | ||
| // phpcs:disable Squiz.Commenting.InlineComment.InvalidEndChar | ||
| // phpcs:disable Squiz.Commenting.InlineComment.SpacingBefore | ||
| // public function is_feature_plugin_build() { | ||
| // return $this->feature()->is_feature_plugin_build(); | ||
| // } | ||
| // phpcs:enable Squiz.PHP.CommentedOutCode | ||
| // phpcs:enable Squiz.Commenting.InlineComment.InvalidEndChar | ||
| // phpcs:enable Squiz.Commenting.InlineComment.SpacingBefore |
There was a problem hiding this comment.
Any reason we're commenting out those functions?
There was a problem hiding this comment.
They aren't used and it seems reasonable to keep it around in case we add new blocks in future that should be behind this feature flag. It would be easier to reinstate by uncommenting this than looking for the PR that removed it and re-adding it that way (I think).
Though I do see a bunch in FeatureGating.php that aren't used and also not commented out. Should we keep it around uncommented?
|
Size Change: -246 B (0%) Total Size: 871 kB
ℹ️ View Unchanged
|
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
opr
added
status: needs review
focus: blocks
rubikuserbot
requested review from
a team and
wavvves
and removed request for
a team
We might need this later, so keeping it around seems useful.
This reverts commit bec6ed8.
opr
force-pushed
the
update/include-cart-checkout-blocks
branch
from
ce78586
to
8309382
Compare
opr
added
the
status: blocker
ralucaStan
approved these changes
Aug 12, 2022
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
tarunvijwani
approved these changes
Aug 15, 2022
tarunvijwani
added
the
type: enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will graduate the Cart and Checkout Blocks so they are available even when WooCommerce Blocks is not running as a feature plugin (i.e. it is included in WooCommerce Core).
To achieve this, I ensured both blocks, and their inner blocks were registered using
registerBlockTyperather thanregisterFeaturePluginBlockType-registerFeaturePluginBlockTypehas been commented out, but left in thefeature-flags.tsfile so it can easily be reinstated in future if we ever add a feature-plugin-only block.I then found all instances in PHP where classes were only registered if WooCommerce Blocks was running as a feature plugin (Payments Api was the only place).
There was also an inbox notification added in #4518 to surface these blocks to a certain subset of users, however this message is defunct. I removed the code to add this notification, but left the code to delete it. This should ensure any sites that still have this message have it removed.
Fixes #6699
Other Checks
Testing
Automated Tests
User Facing Testing
npm run build.blocks.iniwith the following config:Cart
Checkout
Allow customers to create an account during checkoutandAllow customers to log into an existing account during checkout.create accountbox when entering your details.SW19 1AAif in UK).Manual testing for Rubik only
After trying all the steps above, please:
pluginsdirectory, run:npx @wordpress/create-block -t @woocommerce/extend-cart-checkout-block checkout-integration.Checkout Integrationplugin in your dashboard.+ extra data!(this is from thecheckout integrationplugin).Denver. Ensure the COD option disappears from available payment methods.Data passed to this component: This is some example data from the server- this signifies Slot/Fill is working.WooCommerce Visibility
Changelog