This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Prevent Express Checkout block from being cut off #7152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
status: needs review
type: bug
rubikuserbot
requested review from
a team and
tarhi-saad
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
|
Size Change: +8 B (0%) Total Size: 874 kB
ℹ️ View Unchanged
|
tarunvijwani
suggested changes
Sep 19, 2022
There was a problem hiding this comment.
Thank you for working on this, @nielslange! It works great! 👍
I see we have some overlapping/cutting on the step number as well. I think we can fix both of these by adding some padding under .block-editor-block-list__layout in assets/js/blocks/checkout/styles/editor.scss file:
| Before | After |
|---|---|
 |
 |
Thanks for your review, @tarunvijwani, and suggesting the change. I just applied it, but went with
|
tarunvijwani
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Thank you, @nielslange! The reason why I wanted to add padding everywhere as it will fix it from all sides. It is looking good now. However, on the other sides, we still have some overlapping screenshots:
It is not visible though, it won't impact any user experience, and we have this on the Cart block as well. Approving the changes, let's 🚢 it. 👍
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
I would not call these overlaps, @tarunvijwani. By default, Gutenberg shows the border in synch with the edges of a block:
In comparison, the Express Payments block and the Step Numbers both overlapped, meaning they were crossing the border of the block. That said, thanks for reviewing this PR and for explaining what you had in mind by "overlapping" elements. |
|
Gotcha! Thank you, @nielslange, for sharing the details! 🙂 |
nielslange
deleted the
fix/6885-prevent-express-checkout-block-from-being-cut-off
branch
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
* Prevent Express Checkout block from being cut off * Prevent step numbers from being cut off in editor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6885
Notes
When activating Express Checkout as a payment option, the Express Checkout block is cut off when selecting the Checkout block in the editor. This PR aims to solve this problem.
Screenshots
Testing
User Facing Testing
/wp-admin/admin.php?page=wc-settings&tab=checkoutand activate the payment methodStripeso that the Express Payment block becomes visible.WooCommerce Visibility
Performance Impact
Changelog