This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add Product Query Support for Atomic SKU Block #7385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielwrobert
added
type: refactor
|
The release ZIP for this PR is accessible via: |
|
Size Change: +29 B (0%) Total Size: 990 kB
ℹ️ View Unchanged
|
danielwrobert
changed the title
danielwrobert
added
the
block-type: product-query
danielwrobert
force-pushed
the
add/atomic-sku-pq-support
branch
from
5bee5ec
to
2d34612
Compare
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
danielwrobert
force-pushed
the
add/atomic-sku-pq-support
branch
from
4e60efa
to
1fcf246
Compare
rubikuserbot
requested review from
a team and
Aljullu
and removed request for
a team
danielwrobert
requested review from
sunyatasattva,
gigitux,
imanish003 and
dinhtungdu
imanish003
suggested changes
Nov 9, 2022
There was a problem hiding this comment.
The UI of the block is identical to on the editor side.
For me, UI looks different in editor vs frontend.
| Editor | Frontend |
|---|---|
 |
 |
Also, in this PR for the Rating block, you converted js to ts. I am not sure if that is something we wanna cover in this PR too.
danielwrobert
force-pushed
the
add/atomic-sku-pq-support
branch
from
1fcf246
to
d6952b0
Compare
|
@imanish003 nice catch, thank you! Fixed in d6952b0. The TS conversion took place separately but I have rebased this PR to include those changes from |
TypeScript Errors ReportFiles with errors: 440
assets/js/atomic/blocks/product-elements/sku/index.ts
|
danielwrobert
commented
Nov 10, 2022
| @@ -17,11 +17,16 @@ import { | |||
| } from './constants'; | |||
|
|
|||
| const blockConfig: BlockConfiguration = { | |||
| ...sharedConfig, | |||
There was a problem hiding this comment.
Just want to confirm we don't need this here, as we're spreading/merging the same config object in the registerExperimentalBlockType function below.
It seems redundant to spread it here in this definition, unless I'm missing something.
imanish003
approved these changes
Nov 10, 2022
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
danielwrobert
force-pushed
the
add/atomic-sku-pq-support
branch
2 times, most recently
from
b2fab83
to
f458d5c
Compare
- Adds isDescendentOfQueryLoop attribute and sets up usage in editor. - Connects Context (via useContext) in editor. - Sets up necessary hierarchy in block index file settings.
Reassign parent array to ancestor array which allows for blocks to be included with more flexibility - i.e., added within groups that are children of the ancestor block.
SSR markup was accidentally using rating classname instead of sku so it was not applying the proper text transform seen in the editor.
This keeps things consistent with the type naming on the other blocks.
We don't need to spread the `sharedConfig` object into the `blockConfig` object when defining `blockConfig` since we spread/merge these two objects when registering the block via `registerExperimentalBlockType`.
danielwrobert
force-pushed
the
add/atomic-sku-pq-support
branch
from
3a81110
to
71aace4
Compare
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
* Add attributes, settings, and editor PQ settings. - Adds isDescendentOfQueryLoop attribute and sets up usage in editor. - Connects Context (via useContext) in editor. - Sets up necessary hierarchy in block index file settings. * Update parent inner blocks config. Reassign parent array to ancestor array which allows for blocks to be included with more flexibility - i.e., added within groups that are children of the ancestor block. * Add dynamic render function for PQ support. * Update to use correct classnames on PHP side. SSR markup was accidentally using rating classname instead of sku so it was not applying the proper text transform seen in the editor. * Rename BlockAttributes type to Attributes This keeps things consistent with the type naming on the other blocks. * Remove redundant spread of sharedConfig object. We don't need to spread the `sharedConfig` object into the `blockConfig` object when defining `blockConfig` since we spread/merge these two objects when registering the block via `registerExperimentalBlockType`. * bot: update checkstyle.xml * bot: update checkstyle.xml * Empty commit to trigger checks. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Product Query support for the atomic SKU block.
On the client side, when the SKU Block is used within the Product Query block, the markup will be rendered on the server side - no javascript related to the SKU block will be loaded.
Fixes #7332
Testing
npm start(need to run thestartcommand to catch the experimental flags).woocommerce/product-skublock to the Product QueryINNER_BLOCKS_TEMPLATEinassets/js/blocks/product-query/constants.tsunder line 54 (only for testing, remove afterwards).product-sku-frontend.js).product-sku-frontend.jsis loaded.WooCommerce Visibility