This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Convert product-elements/image to TypeScript #7572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… .editorconfig file enforces 2 spaces.
Jobs renaming.
nielslange
added
type: enhancement
rubikuserbot
requested review from
a team and
wavvves
and removed request for
a team
nielslange
requested review from
a team and
sunyatasattva
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
|
Size Change: +216 B (0%) Total Size: 970 kB
ℹ️ View Unchanged
|
…thub.com:woocommerce/woocommerce-blocks into update/7091-convert-product-elements-image-to-TS
…thub.com:woocommerce/woocommerce-blocks into update/7091-convert-product-elements-image-to-TS
|
Thanks for your review, @sunyatasattva. I addressed most of your feedback, but left two questions where I'm not sure what you meant. I also addressed all TS errors, except two errors in |
|
Thank you for addressing the feedback! For the TS errors in the import, I wonder if we should ts-ignore them. That's a genuine question because on the code I'm working on I have literally the same situation (and did not |
sunyatasattva
approved these changes
Nov 17, 2022
…thub.com:woocommerce/woocommerce-blocks into update/7091-convert-product-elements-image-to-TS
…thub.com:woocommerce/woocommerce-blocks into update/7091-convert-product-elements-image-to-TS
|
Thanks for your reviews, @wavvves and @sunyatasattva! With all changes approved, no new introduces TS errors and all tests passed, I'm going to merge this PR now. 🎉 |
nielslange
deleted the
update/7091-convert-product-elements-image-to-TS
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7091
Currently, the
product-elements/imageis still written in JS and is using prop-types for type checking. This PR aims to convertproduct-elements/imageto TypeScript.Testing
User Facing Testing
Single Product blockto it.Product Image inner blockis still visible.