This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Style Book: Fix useForcedLayout to prevent breaking style book
#8243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because by the time we reach this line, innerBlocks will be an empty array (or we wouldn't make it this far) and if nextBlocks contains ANY items it will, by definition be unequal, so a length check is simpler and more performant. Also we can remove the dependence on yet another lodash function by doing it this way.
opr
added
status: needs review
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/cart-checkout-shared/use-forced-layout.ts
|
|
Size Change: 0 B Total Size: 1.08 MB
ℹ️ View Unchanged
|
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
This was referenced Jan 23, 2023
senadir
reviewed
Jan 26, 2023
| @@ -116,6 +115,7 @@ export const useForcedLayout = ( { | |||
|
|
|||
| const registry = useRegistry(); | |||
| useEffect( () => { | |||
| let templateSynced = false; | |||
There was a problem hiding this comment.
Wouldn't templateSynced get reset on every re-render, or is the useRegistry here stable?
There was a problem hiding this comment.
It seems stable, logging this happens only once when a block is rendered for the first time.
4 tasks
4 tasks
nielslange
changed the title
useForcedLayout to prevent breaking style bookuseForcedLayout to prevent breaking style book
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we will update
useForcedLayoutto check if it has already dispatchedreplaceInnerBlocks- if it has we won't do that again.The hook subscribes to the block editor registry and the callback is executed when a data store changes. We updated the second argument of
subscribeso it only listens for changes oncore/block-editor.When the callback is executed, if the current block does not have any inner blocks, but it should, then
replaceInnerBlocksis dispatched, causing these blocks to be added. Once they are added, then this shouldn't need to be done again, that is why we introduced thetemplatesSyncedvariable to track this, per hook.Fixes #8179
Fixes #8177
Fixes #8178
Testing
Internal developer testing - do not include these in testing notes.
wp-content/pluginsdirectory, run:npx @wordpress/create-block -t @woocommerce/extend-cart-checkout-block newsletter-pluginUser Facing Testing
WooCommerce Visibility
Performance Impact
This should have a slight performance increase in the editor due to
useForcedLayoutdoing less work once templates have already been synced.Changelog