This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
WooCommerce Classic Template block: Fix error on clearing customizations on Woo Templates #9759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thealexandrelara
changed the title
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +290 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
thealexandrelara
added
type: bug
woocommercebot
requested review from
a team and
Aljullu
and removed request for
a team
Aljullu
reviewed
Jun 9, 2023
There was a problem hiding this comment.
The PR is testing well, but I wasn't able to reproduce the issue in trunk. I tried with the steps from #9637 and the ones from this PR. I might be missing an important step somewhere. 😕
When the template renders, modify it by adding or removing blocks. Once you finish customizing it, on the top right side, click on Save;
Does it matter if I have the blockified template or the template is using the WooCommerce Single Product Block? Also, does it matter if the other WC templates are blockified or using the legacy block?
When I first tried reproducing the issue, I wasn't able to reproduce it as well. I did a fresh install using the same versions for WordPress, WooCommerce and WooCommerce blocks that are in the issue #9637 and just then I manage to reproduce it
In this particular case, it is important that the template have the WooCommerce Single Product Block (the block name in code is Providing a little bit of context, this specific block is only registered for some templates like the Single Product template. While investigating the problem, I confirmed that the block is being correctly registered (when the page is fully loaded, the block has a registered state), I think the problem is about timing. If I click on Clear all customizations button, wait for the confirmation message and visit the Single Product page, the |
Aljullu
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Thanks, @thealexandrelara! I'm not sure what I was doing wrong, I think the issue was that I had the Shop page as the home, so when navigating from one template to the other the Classic Template block was being registered automatically. After changing that I could reproduce the issue consistently. Sorry for the confusion!
I have to say the issue is a bit confusing, but I couldn't find a simpler way to solve it. Your solution works well and code looks good too, so approving. I just left one minor comment, I think it would be nice to add a link to the GH issue or PR for future reference, what do you think? Besides that, LGTM.
thealexandrelara
deleted the
fix/9637-block-error-is-displayed-when-clearing-customizations-for-templates
branch
tarunvijwani
pushed a commit
that referenced
this pull request
Jun 13, 2023
…ons on Woo Templates (#9759) * Fix Classic Template block error on clearing customizations on template * Add link to issue in JS Doc
tarunvijwani
added a commit
that referenced
this pull request
Jun 13, 2023
* Empty commit for release pull request * Update Hero Product 3-split pattern image * Update Banner Pattern To Replace Unsplash Image (#9760) * Update Banner to replace Unsplash image. Replaces the Unsplash image with a CCO licensed image from Pxhere. Also updates the CTA button to link to the Shop page, by default. * Remove extra padding from top of test column. Vertical alignment was off on the text column due to 60px of top padding. This aligns everythign, as expected. * Update Chessboard pattern images (#9761) * Updathe the Hero Product Split (#9762) * Remove unused pattern image (#9763) * Update Images for the Product Details Patterns (#9764) * Update image for the Product Hero pattern. Replace the Unsplash image with a CCO licensed image from Pxhere. * Update images for Prod List Gallery Desc pattern Replace the Unsplash image with a CCO licensed image from Pxhere for the Product Listing with Gallery and Description pattern. * Remove unneeded Unsplash images. * Update copy for Prod Listing Gallery Desc pattern. * Optimize new image exports. * Update image for the Product Listing pattern. Replace the Unsplash image with a CCO licensed image from Pxhere. * Update images for Product Details pattern. Replace the Unsplash images with CCO licensed images from Pxhere. * Remove unneeded Unsplash image. * Use Relative URLs for Images in the Product Listing Pattern This commit replaces hardcoded URLs with dynamic ones for image placeholders in the `product-listing-with-gallery-and-description.php` pattern file. - The `plugins_url()` function is now used to generate URLs, which correctly points to the images folder within the WooCommerce Blocks plugin directory. This approach provides better flexibility and portability since it doesn't rely on a specific domain or path. The `esc_url()` function is used to ensure the URL is safe to use in the HTML context. - The change is made for a total of four images in the pattern. --------- Co-authored-by: Manish Menaria <the.manish.menaria@gmail.com> * Update/patterns featured category product collection (#9765) * Update image for featured category focus pattern * Update image for featured category cover image pattern * Update images for featured category triple pattern * Change to wide width * Update links to buttons * Fix typo in hex color value. There was an extra `f` in the hex color value, causing the text to unexpectedly render black. --------- Co-authored-by: Daniel W. Robert <danielwrobert@gmail.com> * Update/collection pattern images (#9766) * Update featured collections images * Add shop link to shop by price pattern * Update hero product pattern title (#9769) * Remove unused pattern image (#9770) * Add 10.4.2 changelog in readme.txt * Update version number to 10.4.2 * Add testing instructions for 10.4.2 * Add 9769 PR testing steps * WooCommerce Classic Template block: Fix error on clearing customizations on Woo Templates (#9759) * Fix Classic Template block error on clearing customizations on template * Add link to issue in JS Doc * Change the way of debug check of tests-mysql container (#9794) * Add alt text to images used in patterns describing their purpose (#9788) * Add alt text to images used in patterns describing their purpose * Replace 1/3 notation with 1 out of 3, so it's better handled byt screen readers * Update testing instructions to include 9759 PR * Update zip to include 9759 PR * Remove 9759 PR from testing instructions --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alba Rincón <alba.rincon@automattic.com> Co-authored-by: Daniel W. Robert <danielwrobert@users.noreply.github.com> Co-authored-by: Alba Rincón <albarin@users.noreply.github.com> Co-authored-by: Manish Menaria <the.manish.menaria@gmail.com> Co-authored-by: Roy Ho <roykho77@gmail.com> Co-authored-by: Daniel W. Robert <danielwrobert@gmail.com> Co-authored-by: Tarun Vijwani <tarun.vijwani@automattic.com> Co-authored-by: Alexandre Lara <allexandrelara@gmail.com> Co-authored-by: Karol Manijak <karol.manijak@automattic.com>
gigitux
added a commit
that referenced
this pull request
Jun 21, 2023
* Empty commit for release pull request * Update Hero Product 3-split pattern image * Update Banner Pattern To Replace Unsplash Image (#9760) * Update Banner to replace Unsplash image. Replaces the Unsplash image with a CCO licensed image from Pxhere. Also updates the CTA button to link to the Shop page, by default. * Remove extra padding from top of test column. Vertical alignment was off on the text column due to 60px of top padding. This aligns everythign, as expected. * Update Chessboard pattern images (#9761) * Updathe the Hero Product Split (#9762) * Remove unused pattern image (#9763) * Update Images for the Product Details Patterns (#9764) * Update image for the Product Hero pattern. Replace the Unsplash image with a CCO licensed image from Pxhere. * Update images for Prod List Gallery Desc pattern Replace the Unsplash image with a CCO licensed image from Pxhere for the Product Listing with Gallery and Description pattern. * Remove unneeded Unsplash images. * Update copy for Prod Listing Gallery Desc pattern. * Optimize new image exports. * Update image for the Product Listing pattern. Replace the Unsplash image with a CCO licensed image from Pxhere. * Update images for Product Details pattern. Replace the Unsplash images with CCO licensed images from Pxhere. * Remove unneeded Unsplash image. * Use Relative URLs for Images in the Product Listing Pattern This commit replaces hardcoded URLs with dynamic ones for image placeholders in the `product-listing-with-gallery-and-description.php` pattern file. - The `plugins_url()` function is now used to generate URLs, which correctly points to the images folder within the WooCommerce Blocks plugin directory. This approach provides better flexibility and portability since it doesn't rely on a specific domain or path. The `esc_url()` function is used to ensure the URL is safe to use in the HTML context. - The change is made for a total of four images in the pattern. --------- Co-authored-by: Manish Menaria <the.manish.menaria@gmail.com> * Update/patterns featured category product collection (#9765) * Update image for featured category focus pattern * Update image for featured category cover image pattern * Update images for featured category triple pattern * Change to wide width * Update links to buttons * Fix typo in hex color value. There was an extra `f` in the hex color value, causing the text to unexpectedly render black. --------- Co-authored-by: Daniel W. Robert <danielwrobert@gmail.com> * Update/collection pattern images (#9766) * Update featured collections images * Add shop link to shop by price pattern * Update hero product pattern title (#9769) * Remove unused pattern image (#9770) * Add 10.4.2 changelog in readme.txt * Update version number to 10.4.2 * Add testing instructions for 10.4.2 * Add 9769 PR testing steps * WooCommerce Classic Template block: Fix error on clearing customizations on Woo Templates (#9759) * Fix Classic Template block error on clearing customizations on template * Add link to issue in JS Doc * Change the way of debug check of tests-mysql container (#9794) * Add alt text to images used in patterns describing their purpose (#9788) * Add alt text to images used in patterns describing their purpose * Replace 1/3 notation with 1 out of 3, so it's better handled byt screen readers * Update testing instructions to include 9759 PR * Update zip to include 9759 PR * Remove 9759 PR from testing instructions * Mini Cart Block: show the total price, including tax, according to the option (#9878) * Mini Cart Block: show the total price, including tax, according to the option * Fix tests in PR 9878 (#9880) * add unit test --------- Co-authored-by: Karol Manijak <karol.manijak@automattic.com> * Mini-Cart: don't include shipping price (#9914) * Products Block: fix grid view with Gutenberg 16 (#9916) * Revert "fix products block layout on gutenberg 16 (#9886)" This reverts commit f1e5dd7. * add post_template_has_support_for_grid_view setting * add testing instructions * bump version * update zip link * Empty commit for release pull request * update link --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alba Rincón <alba.rincon@automattic.com> Co-authored-by: Daniel W. Robert <danielwrobert@users.noreply.github.com> Co-authored-by: Alba Rincón <albarin@users.noreply.github.com> Co-authored-by: Manish Menaria <the.manish.menaria@gmail.com> Co-authored-by: Roy Ho <roykho77@gmail.com> Co-authored-by: Daniel W. Robert <danielwrobert@gmail.com> Co-authored-by: Tarun Vijwani <tarun.vijwani@automattic.com> Co-authored-by: Alexandre Lara <allexandrelara@gmail.com> Co-authored-by: Karol Manijak <karol.manijak@automattic.com> Co-authored-by: Luigi Teschio <gigitux@gmail.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the user clears the customizations made on the Single Product template and visits the template page without refreshing the page, an error was occurring that prevented the WooCommerce Classic Template block from being rendered on the Editor.
This PR fixes that error by replacing the 'core/missing' block with the original block (WooCommerce Classic Template) when the template has support to the classic block and the block is already registered.
Walkthrough
🤖 Generated by Copilot at b78ab3d
parsefunction to parse block content into block object (link)dispatchanddebouncefunctions to dispatch actions and limit function calls (link)tryToRecoverClassicTemplateBlockWhenItFailsToRenderfunction to replace 'core/missing' block with original Classic Template block if it fails to render (link)tryToRecoverClassicTemplateBlockWhenItFailsToRenderif block registered and template supports Classic Template block (link, link)subscribefunction with namespace argument of 'core/blocks-editor' to limit subscription scope to block editor store (link)Fixes #9637
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Before the changes, the code was subscribing to all events from the
@wordpress/data, but now the subscription is restricted to the changes on the 'core/block-editor' storage so possible the performance will be better after merging these changes.Changelog