This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Account for classic theme support of template parts #9780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
nerrad
commented
Jun 9, 2023
nerrad
added
type: enhancement
|
Size Change: +1.04 kB (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
|
Yup! Please do :) |
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
Note this logic is currently not right - just a quick implementation for testing POC
Aljullu
removed
the
status: stale
Aljullu
force-pushed
the
add/template-part-support-classic-themes
branch
from
540d07f
to
64b79d0
Compare
Aljullu
changed the title
Aljullu
requested review from
a team and
danieldudzic
and removed request for
a team
|
@Aljullu I will review this today for you |
tjcafferkey
reviewed
Jul 12, 2023
src/BlockTemplatesController.php
Outdated
| @@ -295,7 +295,7 @@ public function get_block_file_template( $template, $id, $template_type ) { | |||
| * @return array | |||
| */ | |||
| public function add_block_templates( $query_result, $query, $template_type ) { | |||
| if ( ! BlockTemplateUtils::supports_block_templates() ) { | |||
| if ( ! BlockTemplateUtils::supports_block_templates( 'wp_template_part' ) ) { | |||
There was a problem hiding this comment.
I think we'd benefit from a comment here on why wp_template_part for context.
There was a problem hiding this comment.
Actually, after taking another look, I think this should be $template_type instead of wp_template_part. Ie, if we are loading Templates, we want to check if the theme supports templates, not template parts.
I changed it in 1843a9a. Also, I think now the code is self-explanatory, do you agree?
There was a problem hiding this comment.
Yeah, I think you're right. I just checked the filter params to be sure it was always going to be one of the two (wp_template_part / wp_template ) and it looks to be the case.
There was a problem hiding this comment.
I also re-tested and everything works as expected from what I can see unless the E2E tests pick up anything.
tjcafferkey
approved these changes
Jul 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classic themes are able to register support for template parts, so it'd be good to account for that with our registration of custom Woo Template Parts such as what is utilized for the Mini-Cart block.
Testing
User Facing Testing
User testing requires utilizing a classic WordPress theme which has implemented support for template parts (commonly via adding
add_theme_support( 'block-template-parts' );to the themesfunctions.phpfile via a callback on theafter_setup_themeaction hook:Once that is in place...
WooCommerce Visibility
Changelog