This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add new Discount banner pattern
#9936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
kmanijak
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +28 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
kmanijak
suggested changes
Jun 22, 2023
There was a problem hiding this comment.
Looks good!
I checked the banner on various styles and found one caveat. On Canary (TT3 theme) the font is a big bigger and there's not enough width for "40% off". And because of the line-height: 0 it's stack like in the image:
But I understand it's opinionated and should work well in MOST cases, not EVERY case. Hence just mentioning it, but I don't think that's a must.
Also, on designs all the text is left-aligned, while "40% off" seems to have whitespace around it.
Removing them could actually help with the text wrapping in Canary!
|
Thanks for the review @kmanijak! I've fixed your comments and also added some hardcoded colors that were missing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs adds the new
Discount bannerpattern.Fixes #9930
Screenshots
Testing
User-Facing Testing
Discount bannerpattern and save.Shop nowbutton links to the shop page.WooCommerce Visibility
Changelog