This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add new Product collection banner pattern
#9953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
nefeline
reviewed
Jun 23, 2023
|
@nefeline @thealexandrelara I've updated with a new image from pxhere, same place where Shaun got the other ones, let me know what you think about it, it may be a better fit than the other one :) |
Was the decision for us to use our best judgment and select another image until @shaunandrews is back? I saw the convo with @danielwrobert on Slack but wanted to double-check. If that's the case, all good! |
I know Dan was searching for images but he didn't say if he found anything in the end. I don't think we agreed on anything concrete, I'll ping Jarek to have his opinion as well. 
|
👍 Sounds good! |
|
Hi there! I think Shaun intended to showcase travel services or leisure products in this block, so this image could fit well. We should center it to keep the composition. Please send me the dimensions if you need it cropped. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new
Product collection bannerpattern.Fixes #9934
Screenshots
Note: the link in this screenshot was broken.
Testing
User-Facing Testing
Product collection bannerpattern and save.Shop nowbutton links to the shop page.WooCommerce Visibility
Changelog