This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Return null or object for ImageAttachmentSchema response #9962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
status: needs review
type: bug
woocommercebot
requested review from
a team and
opr
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.35 MB ℹ️ View Unchanged
|
mikejolley
suggested changes
Jun 22, 2023
There was a problem hiding this comment.
The docblock needs changing but yes, this is what was needed.
Can we ensure that all consumers of these endpoints continue to function before merging. I don't think it will break any backwards compatibility because it would I think be treated as an object anyway, but let's be certain.
Test wise, you could test the response for the cart endpoint and ensure that images are either null or received as an object with said properties. This would be added to the PHP test suite.
Thanks for your review, @mikejolley. I just added the
Thanks for pointing this out. I'll create additional test cases to guarantee that this change will remain backwards compatible. |
nielslange
force-pushed
the
fix/9908-return-null-or-object-for-ImageAttachmentSchema-response
branch
from
29af5e4
to
fd3c543
Compare
mikejolley
approved these changes
Jul 11, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
nielslange
force-pushed
the
fix/9908-return-null-or-object-for-ImageAttachmentSchema-response
branch
from
fd3c543
to
df08bf3
Compare
|
Thanks for your reviews, @mikejolley and @opr! 🙌 |
nielslange
deleted the
fix/9908-return-null-or-object-for-ImageAttachmentSchema-response
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9908
In #9908, @whywilson reported:
Testing
Automated Tests
The affected unit test can be executed using the following commands:
User Facing Testing
[YOUR-URL]/wp-json/wc/store/products/categoriesand replace[YOUR-URL]with the URL of your test site.[YOUR-URL]/wp-json/wc/store/products/categories/[ID]and replace[ID]with the ID of the test product category.{ ... "image": null, ... }{ ... "images": { ... }, ... }WooCommerce Visibility
Changelog