Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting: Retain Stripe Data, place in correct spot settings array #810

Merged
merged 2 commits into from Mar 12, 2019

Conversation

psealock
Copy link
Contributor

@psealock psealock commented Mar 4, 2019

Changes proposed in this Pull Request:

Explicitly place the "Retain Stripe Data" setting at the end of the personal_data_retention section of settings instead of appending it as the second to last entry in the settings array.


  • Make sure your changes respect WordPress' coding standards.
  • Did you make changes, or create a new .js file? If Gruntfile.js exists in the repo, make sure to run grunt.

Avoids this issue when Core adds additional settings

screen shot 2019-03-05 at 11 04 50 am

Test instruction

  1. WooCommerce > Settings > Accounts & Privacy
  2. The "Retain Stripe Data" should be the last entry in the "Personal data retention" section.

@mikejolley
Copy link
Member

LGTM although there seems to be a since tag modified which I'm unsure is correct.

Will defer to @woocommerce/extendables :)

Copy link
Member

@roykho roykho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some small notes.

includes/admin/class-wc-stripe-privacy.php Outdated Show resolved Hide resolved
woocommerce-gateway-stripe.php Outdated Show resolved Hide resolved
@psealock psealock force-pushed the fix/settings-array-placement branch from 5d167d9 to 295c899 Compare March 5, 2019 22:46
@psealock
Copy link
Contributor Author

psealock commented Mar 5, 2019

Thanks for the feedback @roykho. I addressed the changes you mentioned.

@roykho roykho merged commit 5c2fb4e into master Mar 12, 2019
@roykho roykho deleted the fix/settings-array-placement branch March 12, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants