Hide Payment Request container until mounting Element #959
Conversation
| @@ -406,12 +406,9 @@ jQuery( function( $ ) { | |||
| } | |||
|
|
|||
| if ( $( '#wc-stripe-payment-request-button' ).length ) { | |||
| $( '#wc-stripe-payment-request-wrapper, #wc-stripe-payment-request-button-separator' ).show(); | |||
There was a problem hiding this comment.
Why did you move the show() call to before the mount() call?
There was a problem hiding this comment.
Not sure if it makes a difference but I'd felt there was a slim chance that the mounting of the button could suffer from the container being hidden (if it reads any layout measurements, for instance), and it made sense to me that the separator would also just be shown earlier as well. Didn't actually test it the other way, but that was why – do you feel differently / prefer to keep one or both elements hidden until after mounting?
There was a problem hiding this comment.
I was just curious if this change was intentional, since before this mount() was before show() and seemed to be working well. Your explanation makes sense, and worst-case-scenario, it just makes no difference :)
dechov
deleted the
fix/855-hide-payment-request-container-until-mount
branch
Fixes #855
Changes proposed in this Pull Request:
Hide Payment Request container until the Element is actually being mounted there. This affects the loading state but primarily it improves cases where no button would show.
Testing in Firefox:
masterI also verified that the appearance is unchanged when the button does show (testing with jurassic.ninja).
grunt.