This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove generic payment method icons (Stripe CC + Cheque) #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- icons should only be used for recognisable brands - generic icons (e.g. credit card) are not recommended
haszari
added
category: extensibility
|
Size Change: +3.9 kB (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
senadir
approved these changes
Aug 11, 2020
nerrad
suggested changes
Aug 11, 2020
There was a problem hiding this comment.
Chatted with @LevinMedia in slack (p1597154267257400-slack-C8X6Q7XQU) and here's a summary:
- confirm that generic icons get removed
- please keep the icon attribute as it will still be needed for things like paypal etc that will get applied in future pulls around payment method select structure.
This reverts commit 1990028.
|
Summary of slack discussion:
|
|
We no longer need a dev note for this. |
senadir
removed
the
needs: dev note
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2669
This fixes a couple of issues by removing the generic icons for some payment methods.
The
PaymentMethodLabelcomponent now no longer needs support for icons - so I've removed this. We might simplify this further - remove the component and allow payment methods to provide a string or custom component for their label. cc @nerrad - this is an extensibility API changeScreenshots
How to test the changes in this Pull Request:
Changelog
May need a dev note - this changes the API/docs for implementing a payment method - specifically the
PaymentMethodLabelinterface has changed.