This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix Cart & Checkout sidebar layout broken in some themes #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
focus: global styles
Issues that involve styles/css/layout structure.
labels
Sep 3, 2020
Aljullu
added
block: cart
Issues related to the cart block.
block: checkout
Issues related to the checkout block.
labels
Sep 3, 2020
Size Change: +5 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
Aljullu
changed the title
Fix Cart & Checkout layout broken in some themes
Fix Cart & Checkout sidebar layout broken in some themes
Sep 3, 2020
senadir
approved these changes
Sep 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that it fixes that issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: cart
Issues related to the cart block.
block: checkout
Issues related to the checkout block.
focus: global styles
Issues that involve styles/css/layout structure.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cart and Checkout blocks were not playing well with themes that didn't define
box-sizing: border-box;
for all elements. I discovered that while investigating #3110, but it has been for some time in my todo list, so I decided to create a PR directly.Screenshots
Before:
After:
How to test the changes in this Pull Request:
Changelog