Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix Fees not visible in Cart & Checkout blocks when order doesn't need shipping #3521

Merged
merged 1 commit into from Dec 21, 2020

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Dec 8, 2020

Fixes #3517.

Screenshots

Before:
imatge

After:
imatge

How to test the changes in this Pull Request:

  1. Add this PHP code snippet to any PHP file (for example, woocommerce-gutenberg-products-block.php):
add_action( 'woocommerce_cart_calculate_fees', 'add_fee', 10 );
function add_fee( $cart ) {
	$cart->add_fee( __( 'Fee', 'woo-gutenberg-products-block' ), 100, true );
}
  1. Add a product that doesn't need shipping to your cart and go to the Cart and Checkout blocks.
  2. Verify 'Fees' is listed in the sidebar.

@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Dec 8, 2020
@Aljullu Aljullu requested a review from a team as a code owner December 8, 2020 12:01
@Aljullu Aljullu self-assigned this Dec 8, 2020
@Aljullu Aljullu requested review from senadir and removed request for a team December 8, 2020 12:01
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

Size Change: +103 B (0%)

Total Size: 1.17 MB

Filename Size Change
build/active-filters-frontend.js 8.92 kB +24 B (0%)
build/all-products-frontend.js 34.8 kB +3 B (0%)
build/all-products.js 36.2 kB -1 B
build/all-reviews.js 9.74 kB +1 B
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 3.29 kB -1 B
build/atomic-block-components/add-to-cart-frontend.js 9.01 kB -3 B (0%)
build/atomic-block-components/summary-frontend.js 917 B +1 B
build/attribute-filter-frontend.js 18.3 kB +2 B (0%)
build/attribute-filter.js 12.5 kB +2 B (0%)
build/cart-frontend.js 77.2 kB -13 B (0%)
build/cart.js 40.7 kB +38 B (0%)
build/checkout-frontend.js 92.4 kB -8 B (0%)
build/checkout.js 43 kB +37 B (0%)
build/price-filter-frontend.js 14.9 kB +14 B (0%)
build/price-filter.js 10.3 kB +4 B (0%)
build/reviews-by-category.js 11.8 kB -1 B
build/reviews-by-product.js 13.3 kB -1 B
build/single-product-frontend.js 37.9 kB +1 B
build/vendors.js 439 kB +4 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/active-filters.js 8.92 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 335 B 0 B
build/atomic-block-components/add-to-cart.js 7.53 kB 0 B
build/atomic-block-components/button-frontend.js 2.31 kB 0 B
build/atomic-block-components/button.js 839 B 0 B
build/atomic-block-components/category-list-frontend.js 470 B 0 B
build/atomic-block-components/category-list.js 476 B 0 B
build/atomic-block-components/image-frontend.js 1.68 kB 0 B
build/atomic-block-components/image.js 1.13 kB 0 B
build/atomic-block-components/price-frontend.js 2.29 kB 0 B
build/atomic-block-components/price.js 2.31 kB 0 B
build/atomic-block-components/rating-frontend.js 524 B 0 B
build/atomic-block-components/rating.js 530 B 0 B
build/atomic-block-components/sale-badge-frontend.js 858 B 0 B
build/atomic-block-components/sale-badge.js 862 B 0 B
build/atomic-block-components/sku-frontend.js 389 B 0 B
build/atomic-block-components/sku.js 394 B 0 B
build/atomic-block-components/stock-indicator-frontend.js 569 B 0 B
build/atomic-block-components/stock-indicator.js 573 B 0 B
build/atomic-block-components/summary.js 926 B 0 B
build/atomic-block-components/tag-list-frontend.js 466 B 0 B
build/atomic-block-components/tag-list.js 470 B 0 B
build/atomic-block-components/title-frontend.js 1.21 kB 0 B
build/atomic-block-components/title.js 1.05 kB 0 B
build/blocks.js 3.52 kB 0 B
build/editor-rtl.css 14.6 kB 0 B
build/editor.css 14.6 kB 0 B
build/featured-category.js 7.74 kB 0 B
build/featured-product.js 9.97 kB 0 B
build/handpicked-products.js 7.37 kB 0 B
build/product-best-sellers.js 7.44 kB 0 B
build/product-categories.js 3.22 kB 0 B
build/product-category.js 8.39 kB 0 B
build/product-new.js 7.61 kB 0 B
build/product-on-sale.js 8 kB 0 B
build/product-search.js 3.54 kB 0 B
build/product-tag.js 6.56 kB 0 B
build/product-top-rated.js 7.58 kB 0 B
build/products-by-attribute.js 8.36 kB 0 B
build/reviews-frontend.js 9.38 kB 0 B
build/single-product.js 10.1 kB 0 B
build/style-rtl.css 18.4 kB 0 B
build/style.css 18.4 kB 0 B
build/vendors--atomic-block-components/price-frontend.js 5.65 kB 0 B
build/vendors-style-rtl.css 1.05 kB 0 B
build/vendors-style.css 1.05 kB 0 B
build/wc-blocks-data.js 7.1 kB 0 B
build/wc-blocks-middleware.js 931 B 0 B
build/wc-blocks-registry.js 2.39 kB 0 B
build/wc-payment-method-bacs.js 775 B 0 B
build/wc-payment-method-cheque.js 771 B 0 B
build/wc-payment-method-cod.js 866 B 0 B
build/wc-payment-method-paypal.js 813 B 0 B
build/wc-payment-method-stripe.js 12.1 kB 0 B
build/wc-settings.js 2.59 kB 0 B
build/wc-shared-context.js 1.53 kB 0 B
build/wc-shared-hocs.js 1.66 kB 0 B

compressed-size-action

@Aljullu Aljullu force-pushed the fix/3517-fees-when-no-shipping branch from b2c5523 to 4b1f61e Compare December 9, 2020 07:54
@Aljullu Aljullu added this to the 4.1.0 milestone Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fees not shown in Cart & Checkout blocks for orders that don't need shipping
2 participants