Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Replace IconButton component with Button #3547

Merged
merged 2 commits into from Dec 21, 2020
Merged

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Dec 14, 2020

Fixes #3511.
Fixes #3546.

How to test the changes in this Pull Request:

Fix for #3511

  1. Add the Featured Product to a post or page.
  2. Choose a product and select the block.
  3. Verify the Edit media button looks good and ensure there isn't any JS message in the console with a deprecation message for the IconButton component.
    imatge
  4. Repeat steps 1-3 with Featured Category block.
  5. Add the All Products block to a page.
  6. Click the edit button (pencil icon) and verify the Reset Layout button looks good and there aren't JS errors in the console.
    imatge

Fix for #3546

  1. Add the All Products block to a page (or use the one you just added in the steps above).
  2. Click the edit button (pencil icon) and verify the layout looks like in the screenshot on the right.
Before After
imatge imatge

Changelog

Fix All Products block edit screen.

@Aljullu Aljullu added status: needs review focus: components Work that introduces new or updates existing components. block: all products Issues related to the all products block. labels Dec 14, 2020
@Aljullu Aljullu added this to the 4.1.0 milestone Dec 14, 2020
@Aljullu Aljullu requested a review from a team as a code owner December 14, 2020 10:23
@Aljullu Aljullu self-assigned this Dec 14, 2020
@Aljullu Aljullu requested review from mikejolley and removed request for a team December 14, 2020 10:23
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2020

Size Change: +583 B (0%)

Total Size: 1.17 MB

Filename Size Change
build/all-products.js 36.2 kB -3 B (0%)
build/editor-rtl.css 14.9 kB +295 B (1%)
build/editor.css 14.9 kB +297 B (1%)
build/featured-category.js 7.74 kB -4 B (0%)
build/featured-product.js 9.97 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 8.9 kB 0 B
build/active-filters.js 8.92 kB 0 B
build/all-products-frontend.js 34.8 kB 0 B
build/all-reviews.js 9.74 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 3.29 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 335 B 0 B
build/atomic-block-components/add-to-cart-frontend.js 9.02 kB 0 B
build/atomic-block-components/add-to-cart.js 7.53 kB 0 B
build/atomic-block-components/button-frontend.js 2.31 kB 0 B
build/atomic-block-components/button.js 839 B 0 B
build/atomic-block-components/category-list-frontend.js 470 B 0 B
build/atomic-block-components/category-list.js 476 B 0 B
build/atomic-block-components/image-frontend.js 1.68 kB 0 B
build/atomic-block-components/image.js 1.13 kB 0 B
build/atomic-block-components/price-frontend.js 2.29 kB 0 B
build/atomic-block-components/price.js 2.31 kB 0 B
build/atomic-block-components/rating-frontend.js 524 B 0 B
build/atomic-block-components/rating.js 530 B 0 B
build/atomic-block-components/sale-badge-frontend.js 858 B 0 B
build/atomic-block-components/sale-badge.js 862 B 0 B
build/atomic-block-components/sku-frontend.js 389 B 0 B
build/atomic-block-components/sku.js 394 B 0 B
build/atomic-block-components/stock-indicator-frontend.js 569 B 0 B
build/atomic-block-components/stock-indicator.js 573 B 0 B
build/atomic-block-components/summary-frontend.js 916 B 0 B
build/atomic-block-components/summary.js 926 B 0 B
build/atomic-block-components/tag-list-frontend.js 466 B 0 B
build/atomic-block-components/tag-list.js 470 B 0 B
build/atomic-block-components/title-frontend.js 1.21 kB 0 B
build/atomic-block-components/title.js 1.05 kB 0 B
build/attribute-filter-frontend.js 18.3 kB 0 B
build/attribute-filter.js 12.5 kB 0 B
build/blocks.js 3.47 kB 0 B
build/cart-frontend.js 77.2 kB 0 B
build/cart.js 40.6 kB 0 B
build/checkout-frontend.js 92.4 kB 0 B
build/checkout.js 43 kB 0 B
build/handpicked-products.js 7.37 kB 0 B
build/price-filter-frontend.js 14.9 kB 0 B
build/price-filter.js 10.3 kB 0 B
build/product-best-sellers.js 7.44 kB 0 B
build/product-categories.js 3.22 kB 0 B
build/product-category.js 8.39 kB 0 B
build/product-new.js 7.61 kB 0 B
build/product-on-sale.js 8 kB 0 B
build/product-search.js 3.54 kB 0 B
build/product-tag.js 6.56 kB 0 B
build/product-top-rated.js 7.58 kB 0 B
build/products-by-attribute.js 8.36 kB 0 B
build/reviews-by-category.js 11.8 kB 0 B
build/reviews-by-product.js 13.3 kB 0 B
build/reviews-frontend.js 9.38 kB 0 B
build/single-product-frontend.js 37.9 kB 0 B
build/single-product.js 10.1 kB 0 B
build/style-rtl.css 18.4 kB 0 B
build/style.css 18.4 kB 0 B
build/vendors--atomic-block-components/price-frontend.js 5.65 kB 0 B
build/vendors-style-rtl.css 1.05 kB 0 B
build/vendors-style.css 1.05 kB 0 B
build/vendors.js 439 kB 0 B
build/wc-blocks-data.js 6.89 kB 0 B
build/wc-blocks-middleware.js 931 B 0 B
build/wc-blocks-registry.js 2.39 kB 0 B
build/wc-payment-method-bacs.js 775 B 0 B
build/wc-payment-method-cheque.js 771 B 0 B
build/wc-payment-method-cod.js 866 B 0 B
build/wc-payment-method-paypal.js 813 B 0 B
build/wc-payment-method-stripe.js 12.1 kB 0 B
build/wc-settings.js 2.59 kB 0 B
build/wc-shared-context.js 1.53 kB 0 B
build/wc-shared-hocs.js 1.66 kB 0 B

compressed-size-action

@haszari
Copy link
Member

haszari commented Dec 21, 2020

Just checking - are we good for backward compat with this change? I'm assuming IconButton is available in all our supported WP versions.

🎉 Aha I see from the linked issue that we are all good #3511

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: all products Issues related to the all products block. focus: components Work that introduces new or updates existing components. type: compatibility
Projects
None yet
3 participants