This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
add missing aria-label for stars image in review-list-item component #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralucaStan
added
status: needs review
focus: accessibility
The issue/PR is related to accessibility.
labels
Jan 19, 2021
Size Change: +44 B (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing well. I tested with Orca screen reader and it correctly read the rating. Code also looks good, good job! 👌
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Jan 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: accessibility
The issue/PR is related to accessibility.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an aria-label for the stars image in the review-list-item component for a11y purposes.
Fixes #1675
Accessibility
Screenshots
How to test the changes in this Pull Request:
role="img"
&aria-label="Rated X out of 5"
aria-label
attributeChangelog