This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update @woocommerce/components #4100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: blocked
Aljullu
removed
the
status: blocked
Aljullu
force-pushed
the
fix/update-woocommerce-components
branch
from
6e23123
to
57beca4
Compare
Aljullu
commented
May 17, 2021
| @@ -214,7 +214,7 @@ const getMainConfig = ( options = {} ) => { | |||
| ], | |||
| resolve: { | |||
| ...resolve, | |||
| extensions: [ '.js', '.ts', '.tsx' ], | |||
| extensions: [ '.js', '.jsx', '.ts', '.tsx' ], | |||
There was a problem hiding this comment.
I don't really know why this is needed but I couldn't get npm build to work without it. 😕
Aljullu
commented
May 17, 2021
| '%d Review', | ||
| '%d Reviews', | ||
| '%d review', | ||
| '%d reviews', |
There was a problem hiding this comment.
We didn't have a consistent casing style for strings shown in the count bubble. In 981fa51 I made all of them to use sentence casing.
|
Size Change: -177 kB (-15%) 👏 Total Size: 979 kB
ℹ️ View Unchanged
|
Aljullu
force-pushed
the
fix/update-woocommerce-components
branch
2 times, most recently
from
0e6154a
to
fdf1e96
Compare
Aljullu
changed the title
|
@opr just a heads-up that this PR is no longer in progress and is now ready for review. 🙂 cc @frontdevde since it should fix #4192, which affects the block editor. |
opr
reviewed
May 18, 2021
There was a problem hiding this comment.
Featured category block
I notice on the Featured Product block, when I'm done changing the setting inside the block and viewing the preview, I can use this pencil icon to return to the settings:
This is not present on the Featured Category block, once you've chosen a category it looks like you're stuck with it unless you delete the block and start again.
Products by Attribute
I noticed this strange behaviour when choosing a different attribute in the inspector controls, the changes weren't reflected in the block and vice/versa. Loom video
Filter Product by Attribute
Adding this block shows: This block has encountered an error and cannot be previewed.
I get this error in console too
Console error
edit.js:297 Uncaught TypeError: Cannot read property 'isCompact' of undefined
at renderAttributeControl (edit.js:297)
at renderEditMode (edit.js:369)
at Edit (edit.js:385)
at renderWithHooks (react-dom.development.js:14938)
at mountIndeterminateComponent (react-dom.development.js:17617)
at beginWork (react-dom.development.js:18731)
at HTMLUnknownElement.callCallback (react-dom.development.js:182)
at Object.invokeGuardedCallbackDev (react-dom.development.js:231)
at invokeGuardedCallback (react-dom.development.js:286)
at beginWork$1 (react-dom.development.js:23338)
renderAttributeControl @ edit.js:297
renderEditMode @ edit.js:369
Edit @ edit.js:385
renderWithHooks @ react-dom.development.js:14938
mountIndeterminateComponent @ react-dom.development.js:17617
beginWork @ react-dom.development.js:18731
callCallback @ react-dom.development.js:182
invokeGuardedCallbackDev @ react-dom.development.js:231
invokeGuardedCallback @ react-dom.development.js:286
beginWork$1 @ react-dom.development.js:23338
performUnitOfWork @ react-dom.development.js:22289
workLoopSync @ react-dom.development.js:22265
performSyncWorkOnRoot @ react-dom.development.js:21891
(anonymous) @ react-dom.development.js:11224
unstable_runWithPriority @ react.development.js:2685
runWithPriority$1 @ react-dom.development.js:11174
flushSyncCallbackQueueImpl @ react-dom.development.js:11219
flushSyncCallbackQueue @ react-dom.development.js:11207
discreteUpdates$1 @ react-dom.development.js:22028
discreteUpdates @ react-dom.development.js:803
dispatchDiscreteEvent @ react-dom.development.js:4291
react_devtools_backend.js:2557 The above error occurred in the <Edit> component:
in Edit (created by WithSpokenMessages(Edit))
in WithSpokenMessages(Edit) (created by Edit)
in Edit (created by WithToolbarControls(Edit))
in WithToolbarControls(Edit) (created by WithInspectorControl(WithToolbarControls(Edit)))
in WithInspectorControl(WithToolbarControls(Edit)) (created by WithInspectorControl(WithInspectorControl(WithToolbarControls(Edit))))
in WithInspectorControl(WithInspectorControl(WithToolbarControls(Edit))) (created by WithToolbarControls(WithInspectorControl(WithInspectorControl(WithToolbarControls(Edit)))))
in WithToolbarControls(WithInspectorControl(WithInspectorControl(WithToolbarControls(Edit)))) (created by WithInspectorControls(WithToolbarControls(WithInspectorControl(WithInspectorControl(WithToolbarControls(Edit))))))
in WithInspectorControls(WithToolbarControls(WithInspectorControl(WithInspectorControl(WithToolbarControls(Edit)))))
in Unknown (created by WithDispatch(Component))
in WithDispatch(Component)
in Unknown (created by WithMultipleValidation(WithInspectorControls(WithToolbarControls(WithInspectorControl(WithInspectorControl(WithToolbarControls(Edit)))))))
in WithMultipleValidation(WithInspectorControls(WithToolbarControls(WithInspectorControl(WithInspectorControl(WithToolbarControls(Edit)))))) (created by WithFilters(Edit))
in WithFilters(Edit) (created by BlockEdit)
in BlockEdit (created by BlockListBlock)
in div (created by Block)
in Block (created by BlockListBlock)
in BlockCrashBoundary (created by BlockListBlock)
in BlockListBlock (created by (BlockListBlock))
in (BlockListBlock) (created by ((BlockListBlock)))
in ((BlockListBlock)) (created by WithFontSizeInlineStyles(((BlockListBlock))))
in WithFontSizeInlineStyles(((BlockListBlock))) (created by (WithFontSizeInlineStyles(((BlockListBlock)))))
in (WithFontSizeInlineStyles(((BlockListBlock)))) (created by WithDefaultAttributes((WithFontSizeInlineStyles(((BlockListBlock))))))
in WithDefaultAttributes((WithFontSizeInlineStyles(((BlockListBlock))))) (created by WithFilters(BlockListBlock))
in WithFilters(BlockListBlock) (created by IfCondition(WithFilters(BlockListBlock)))
in IfCondition(WithFilters(BlockListBlock)) (created by WithDispatch(IfCondition(WithFilters(BlockListBlock))))
in WithDispatch(IfCondition(WithFilters(BlockListBlock)))
in Unknown (created by Pure(WithSelect(WithDispatch(IfCondition(WithFilters(BlockListBlock))))))
in Pure(WithSelect(WithDispatch(IfCondition(WithFilters(BlockListBlock))))) (created by Items)
in Items (created by BlockListItems)
in BlockListItems (created by BlockList)
in div (created by BlockList)
in BlockList (created by VisualEditor)
in div (created by WritingFlow)
in WritingFlow (created by VisualEditor)
in div (created by VisualEditor)
in div (created by VisualEditor)
in VisualEditor (created by Layout)
in div (created by ForwardRef(InterfaceSkeleton))
in div (created by ForwardRef(InterfaceSkeleton))
in div (created by ForwardRef(InterfaceSkeleton))
in div (created by ForwardRef(InterfaceSkeleton))
in ForwardRef(InterfaceSkeleton) (created by Layout)
in Layout (created by Editor)
in ErrorBoundary (created by Editor)
in BlockEditorProvider
in Unknown (created by Context.Consumer)
in WithRegistryProvider(BlockEditorProvider) (created by EditorProvider)
in BlockContextProvider (created by EditorProvider)
in EntityProvider (created by EditorProvider)
in EntityProvider (created by EditorProvider)
in EditorProvider
in Unknown (created by Context.Consumer)
in WithRegistryProvider(EditorProvider) (created by Editor)
in DropZoneContextProvider (created by Editor)
in SlotFillProvider (created by Provider)
in SlotFillProvider (created by Provider)
in Provider (created by Editor)
in StrictMode (created by Editor)
in Editor
React will try to recreate this component tree from scratch using the error boundary you provided, BlockCrashBoundary.
overrideMethod @ react_devtools_backend.js:2557
logCapturedError @ react-dom.development.js:19662
logError @ react-dom.development.js:19699
callback @ react-dom.development.js:20879
callCallback @ react-dom.development.js:12625
commitUpdateQueue @ react-dom.development.js:12646
commitLifeCycles @ react-dom.development.js:19993
commitLayoutEffects @ react-dom.development.js:22938
callCallback @ react-dom.development.js:182
invokeGuardedCallbackDev @ react-dom.development.js:231
invokeGuardedCallback @ react-dom.development.js:286
commitRootImpl @ react-dom.development.js:22676
unstable_runWithPriority @ react.development.js:2685
runWithPriority$1 @ react-dom.development.js:11174
commitRoot @ react-dom.development.js:22516
finishSyncRender @ react-dom.development.js:21942
performSyncWorkOnRoot @ react-dom.development.js:21928
(anonymous) @ react-dom.development.js:11224
unstable_runWithPriority @ react.development.js:2685
runWithPriority$1 @ react-dom.development.js:11174
flushSyncCallbackQueueImpl @ react-dom.development.js:11219
flushSyncCallbackQueue @ react-dom.development.js:11207
discreteUpdates$1 @ react-dom.development.js:22028
discreteUpdates @ react-dom.development.js:803
dispatchDiscreteEvent @ react-dom.development.js:4291
General
Some input IDs are duplicated, so using the labels to activate inputs can cause incorrect inputs to be activated. Loom video
Aljullu
force-pushed
the
fix/update-woocommerce-components
branch
from
fdf1e96
to
9da7826
Compare
|
Thanks for the review @opr!
We have an open issue for this: #4177. 🙂
Good catch! This seems to be an issue in
Fixed in: 49a4b44.
Fixed in: 9da7826. |
Sounds OK to me 👍🏼 |
Aljullu
force-pushed
the
fix/update-woocommerce-components
branch
from
9da7826
to
5254fe8
Compare
grogou
pushed a commit
to NovemBit/woocommerce-gutenberg-products-block-fork
that referenced
this pull request
Aug 20, 2021
* Add isCompact prop to components using SearchListControl * Update @woocommerce/components to 6.1.2 * Remove legacy CSS code * Add some CSS rules to override conflicting editor styles * Replace showCount prop with has-count class name * Create ExpandableSearchListItem component * Refactor ProductControl so it uses ExpandableSearchListItem * Update @woocommerce/components to 6.2.0 * Fix @woocommerce/components builds breaking * Fix a11y of expandable item list children * Set categories to an empty array by default * Render compact control in Attribute filter sidebar * Add countLabel to ProductAttributeTermControl * Fix ProductTagControl selected items * Use sentence case for countLabel * Fix wrong margins in block editor * Fix checkbox alignment * Update package-lock.json * Fix withCategories test * Fix JS error in Filter Products by Attribute block * Make input ids unique
opr
added a commit
that referenced
this pull request
Aug 20, 2021
commit 4fccfd8 Merge: 8012b2b e7bd0e6 Author: groguo <eriktadevosyan07@gmail.com> Date: Fri Aug 20 13:17:42 2021 +0000 Merge from trunk commit 8012b2b Author: grogou <eriktadevosyan07@gmail.com> Date: Fri Aug 20 16:53:56 2021 +0400 Escape statuses for sql query Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> commit 304348a Author: grogou <eriktadevosyan07@gmail.com> Date: Fri Aug 20 16:53:18 2021 +0400 Allow custom stock statuses Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> commit b2f01e4 Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 28 06:22:04 2021 +0000 Bring back removed css commit caafffd Author: grogou <eriktadevosyan07@gmail.com> Date: Tue Jul 27 23:35:15 2021 +0400 Update assets/js/blocks/stock-filter/block.js Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> commit ae381de Author: groguo <eriktadevosyan07@gmail.com> Date: Thu Jul 15 06:50:06 2021 +0000 Fixed preview part for stock and attribute filters commit 7df5fea Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Jul 14 20:15:05 2021 +0400 Update index.js commit af0294c Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:43:06 2021 +0000 Review suggestion changes commit 16da253 Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:40:52 2021 +0000 Linter fix commit 594125a Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:37:41 2021 +0000 Removed hideOutOfStock from AllProducts and realized hide out of stock functionality from SQL query commit 94a54e3 Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:21:51 2021 +0000 Created new component for Filters elements labels commit e3d7fb2 Author: aaron <aaron.yor@gmail.com> Date: Wed Jun 2 11:57:06 2021 +0400 Fix label includ path commit c9e3d02 Author: Seghir Nadir <nadir.seghir@gmail.com> Date: Tue Jun 1 09:46:02 2021 +0100 remove usage of mustBeString (#4294) commit b892339 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon May 31 16:07:59 2021 +0100 Lock file maintenance (#4290) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 6de68e4 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Thu May 27 12:57:49 2021 +0100 Check if product can be added to cart before adding ajax class to button (#4265) commit a1ccaf4 Author: Thomas Roberts <thomas.roberts@automattic.com> Date: Wed May 26 16:10:43 2021 +0100 Update version for next release commit 24f882f Author: Thomas Roberts <thomas.roberts@automattic.com> Date: Wed May 26 15:42:21 2021 +0100 Bumping version strings to new version. commit e1fd082 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Wed May 26 15:31:37 2021 +0100 Update link to testing zip commit 35521e5 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Wed May 26 14:04:42 2021 +0100 Fix display of itemised taxes (#4279) * Add price to itemised tax rates & hide Total when itemised taxes are on * Update snapshots for taxes in sidebar commit 7f3a1e6 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 26 08:52:31 2021 +0000 Update dependency downshift to v6.1.3 (#4272) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 593ef2b Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 26 05:04:55 2021 +0000 Update dependency @types/react to v16.14.8 (#4270) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 21f16d6 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 26 03:47:54 2021 +0000 Update dependency @woocommerce/e2e-utils to v0.1.5 (#4271) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 444256e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 26 02:30:17 2021 +0000 Update dependency @types/lodash to v4.14.170 (#4269) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 5f9df57 Author: Thomas Roberts <thomas.roberts@automattic.com> Date: Tue May 25 15:31:03 2021 +0100 Create 5.2.0 testing notes commit 45abda6 Author: Thomas Roberts <thomas.roberts@automattic.com> Date: Tue May 25 14:52:37 2021 +0100 Update package.json npm ci was not working correctly this will fix it. commit c3daa6c Author: Thomas Roberts <thomas.roberts@automattic.com> Date: Tue May 25 14:26:32 2021 +0100 Update changelog and WC tested up to commit 6128309 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Thu May 20 17:56:56 2021 +0100 Revert "Move `TextInput` to checkout package and allow it to be used for input type=number (#4238)" This reverts commit 15c1779. commit 193267b Author: Mike Jolley <mike.jolley@me.com> Date: Tue May 25 12:49:13 2021 +0100 Add key to each `CartTotalItem` (#4240) * Move type defs * Move type guards * Fix imports * Extract prepareTotalItems to TS file * usePaymentMethodInterface as TS file * Fix TS props * Fix currency type defs * Add return type to usePaymentMethodInterface * Add key prop to CartTotalItem * Fixed up js tests * Move SymbolPosition into type-defs package Co-authored-by: Thomas Roberts <thomas.roberts@automattic.com> commit c15e512 Author: Seghir Nadir <nadir.seghir@gmail.com> Date: Tue May 25 10:46:28 2021 +0100 Fix duplicate plugins by using wp.components global in the editor. (#4211) * fix duplicate slotProvider * load file on demand * add comment and load components in blocks as well * add todo block commit e2cf0ba Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Tue May 25 08:43:46 2021 +0100 Hide "including X in taxes" when the amount of tax is 0 (#4262) * Hide "including x in taxes" if tax amount is 0 * Add jest types to tsconfig * Move SHOW_TAXES into component body This is to make the code more testable and allows us to change values. There's no significant performance impact because of this change. * Add tests and snapshots for TotalsFooterItem commit 9b44c88 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon May 24 18:14:37 2021 +0100 Update dependency @octokit/graphql to v4.6.2 (#4230) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 4973132 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon May 24 16:40:05 2021 +0100 Lock file maintenance (#4253) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit b7eabf5 Author: Michael P. Pfeiffer <frontdevde@users.noreply.github.com> Date: Fri May 21 09:53:46 2021 +0200 Block Widgets: hide legacy widgets with a feature-complete block equivalent (#4237) * Block Widgets: hide legacy widgets with block equivalent * Unhide Products and Products by Rating widgets commit 47556b9 Author: Michael P. Pfeiffer <frontdevde@users.noreply.github.com> Date: Fri May 21 09:52:27 2021 +0200 Block Widgets: hide All Products and Filter blocks in the Customizer (#4225) commit 208b212 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Thu May 20 17:56:56 2021 +0100 Move `TextInput` to checkout package and allow it to be used for input type=number (#4238) * Move text-input to checkout package * Pass validation props directly to ValidatedTextInput * Import label relatively instead of from package * Pass validation functions to ValidatedTextInput This is so it doesn't need to get them from useValidationContext. * Add InputProps to ValidatedTextInput This will be used to control additional props on the input element of TextInput * Spread inputProps onto <input> element of TextInput * Export TextInput from @woocommerce/blocks-checkout * Add @woocommerce/blocks-checkout package to tsconfig * Allow styling to be applied to number inputs and when value is 0 * Make style order consistent * Remove inputProps to rely on rest in TextInput * Add specific prop for the inputErrorComponent * Only disallow active state if value is 0 AND type is number * Change all uses of ValidatedTextInput to also pass inputErrorComponent * Revert "Change all uses of ValidatedTextInput to also pass inputErrorComponent" This reverts commit ec734b9. * Revert "Remove inputProps to rely on rest in TextInput" This reverts commit 1fc64cc. * Revert "Revert "Change all uses of ValidatedTextInput to also pass inputErrorComponent"" This reverts commit 110e360. * Revert "Revert "Remove inputProps to rely on rest in TextInput"" This reverts commit aeb0352. * Don't pass errorMessage to ValidatedTextInput commit 55f5bfd Author: Mike Jolley <mike.jolley@me.com> Date: Thu May 20 15:07:12 2021 +0100 Create LICENSE (#4235) commit 0b10f75 Author: Albert Juhé Lluveras <contact@albertjuhe.com> Date: Thu May 20 10:58:59 2021 +0200 Update @woocommerce/components (#4100) * Add isCompact prop to components using SearchListControl * Update @woocommerce/components to 6.1.2 * Remove legacy CSS code * Add some CSS rules to override conflicting editor styles * Replace showCount prop with has-count class name * Create ExpandableSearchListItem component * Refactor ProductControl so it uses ExpandableSearchListItem * Update @woocommerce/components to 6.2.0 * Fix @woocommerce/components builds breaking * Fix a11y of expandable item list children * Set categories to an empty array by default * Render compact control in Attribute filter sidebar * Add countLabel to ProductAttributeTermControl * Fix ProductTagControl selected items * Use sentence case for countLabel * Fix wrong margins in block editor * Fix checkbox alignment * Update package-lock.json * Fix withCategories test * Fix JS error in Filter Products by Attribute block * Make input ids unique commit 587be17 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Wed May 19 10:55:15 2021 +0100 Convert TextInput and ValidatedTextInput to TypeScript (#4226) * Change index file from base/context to .ts This is to stop TS complaining when importing things from here. * Convert ValidatedTextInput to TypeScript * Convert TextInput to TypeScript * Ensure Label accepts correct HTML Attributes Props * Remove PropTypes from TextInput and ValidatedTextInput No longer needed because of TypeScript * Use correct error id to show validation message * Use HTMLElement instead of a specific element type for LabelProps * Update assets/js/base/components/text-input/validated-text-input.tsx Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> * Update assets/js/base/components/text-input/validated-text-input.tsx * Use correct formatting in ValidatedTextInput Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> commit 731c75e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 19 07:36:46 2021 +0000 Update dependency @testing-library/react-hooks to v5.1.3 (#4233) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit ef6ad88 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 19 04:36:44 2021 +0000 Update dependency @types/lodash to v4.14.169 (#4234) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 096463e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 19 03:46:21 2021 +0000 Update dependency @testing-library/react to v11.2.7 (#4232) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 8722839 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 19 02:48:45 2021 +0000 Update dependency @stripe/react-stripe-js to v1.4.1 (#4231) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 2f7e8ed Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 19 01:32:34 2021 +0000 Pin dependency @types/wordpress__deprecated to 2.4.2 (#4229) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 72e851a Author: Raluca Stan <raluca.stan@automattic.com> Date: Tue May 18 15:09:30 2021 +0200 Fix e2e checkout tests and adjust jest setup (#4216) * Fix checkout test - make tests independent & test also for empty cart case - make sure the Order summary is expanded with a better selector * Remove unnecessary localStorage operations from tests * Go to cart page before removing an item from cart * Remove logging observing before tests This removes unnecessary console.log interception. A big part of the logic was done for Puppeteer 1.6.1, but since 3.0.0 message.text() returns string. We allow console.error messages to surface in our tests. Although they don't cause the test to fail it might be a good addition for debugging purposes. commit 7b7119c Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue May 18 11:27:27 2021 +0100 Lock file maintenance (#4212) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 5f84e7d Author: Mike Jolley <mike.jolley@me.com> Date: Tue May 18 10:37:31 2021 +0100 Convert checkout state context provider to Typescript (#4200) * git move to ts files * Type the checkout state provider * Restore for loop for error handling * Types not needed * Consolodate response handling * Unused import * Fix defaults for onCheckoutAfterProcessingWithSuccess etc * Type useEmitResponse and remove isObject checks * useEmitResponse as const * Check that redirectUrl is string * Define actions as const * data.redirectUrl should be truthy * Add redirectURL todo item as followup * remove null fallback commit fccc72b Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Tue May 18 09:10:31 2021 +0100 Move Button and Label components to `@woocommerce/blocks-checkout` package (#4222) * Move Button to checkout package * Move Label to Components Package commit 0b91fbe Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Mon May 17 15:00:57 2021 +0100 Update design of cart and checkout sidebars (#4180) * Update cart/coupon/shipping design * Add order summary heading * Move and style discounts on checkout sidebar * Add rate to tax lines * Ensure the option to display taxes itemised is available to Cart block * Output individual tax items below the total & add styles for this * Add success notice under coupon input on successful coupon addition * Add border to bottom of Totals footer * Show success message when adding coupon * Add padding to cart item rows * Add preview data to cart for when taxes are enabled * Add rate to cart response type * Add showRateAfterTaxName attribute to Cart block * Add control to cart block to show rate percentage after rate name * Add rate % in cart totals only if option is toggled on * Pass showRateAfterTaxName attribute down to TotalsTaxes * Add showRateAfterTaxName to Checkout block * Add control to block editor for showRateAfterTaxName on Checkout * Pass showRateAfterTaxName down to TotalsTaxes in Checkout * Change label for showing tax rates in cart and checkout blocks * Add test to ensure Taxes section shows in Cart block * Add tests for cart sidebar and rate percentages * Remove order summary title from checkout sidebar * Check if taxes are enabled before rendering the option to show rate %s * Add ShippingVia component to show the selected rate in sidebar * Remove value from individual tax rates * Remove bold from Shipping via label * Remove coupon added successfully message * Ensure panel headings that are h2s are the same colour as others * Clean up eslint warnings * Show rate %s by default * Update snapshots following design changes Co-authored-by: Mike Jolley <mike.jolley@me.com> commit 0464883 Author: Albert Juhé Lluveras <contact@albertjuhe.com> Date: Sun May 16 20:00:06 2021 +0200 Don't default to fallback in getSetting if value is falsy (#4202) commit f95f12d Author: Mike Jolley <mike.jolley@me.com> Date: Sun May 16 18:59:32 2021 +0100 Fix es lint warnings (#4206) * Un-used PropTypes import * Avoid global and use ownerDocument * receiveCart return type * ignoreRestSiblings when destructuring for @typescript-eslint/no-unused-vars * Replace lodash find * Use global rather than window * Remove lodash map * move rule to overrides commit db589e7 Author: Raluca Stan <raluca.stan@automattic.com> Date: Sun May 16 19:41:34 2021 +0200 Fix cart and checkout frontend e2e tests (#4199) * Wip: fix e2e fe tests * Test that navigation ends * Fix waitForNavigation * comment out failing php test * click the dom element * Ensure navigation happens by waiting for it. Test page title. * remove skip and update docs * Revert "comment out failing php test" This reverts commit 7c40e8c. * Fix USD from merge conflict * Add missing check for page title * Try page.waitForFunction for text search * test to see checkout page title is correct * test checkout page url on CI * unde jest config change * Fix assertion for checkout page * remove extra localStorage item remove call Co-authored-by: Mike Jolley <mike.jolley@me.com> Co-authored-by: Nadir Seghir <nadir.seghir@gmail.com> commit b9b66f9 Author: Mike Jolley <mike.jolley@me.com> Date: Thu May 13 11:49:39 2021 +0100 Set order status to pending when no payment is needed (#4186) commit 8ed63f7 Author: Mike Jolley <mike.jolley@me.com> Date: Thu May 13 11:21:21 2021 +0100 Remove the need for the `canMakePayment` callback in the editor context (#4188) * Force can pay true in editor context * Update docs commit 90499cb Author: Mike Jolley <mike.jolley@me.com> Date: Thu May 13 11:20:37 2021 +0100 Sync customer data during checkout with draft orders. (#4197) * Update store when email changes * Add pluckEmail helper and convert to TS * improve guard * sync draft order with customer data commit a813c93 Author: Albert Juhé Lluveras <contact@albertjuhe.com> Date: Thu May 13 12:14:15 2021 +0200 Set default store currency to USD in tests (#4203) commit b140893 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu May 13 10:16:04 2021 +0200 Update dependency config to v3.3.6 (#4195) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit d68bb11 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu May 13 10:15:35 2021 +0200 Update dependency cssnano to v4.1.11 (#4196) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit beadbab Author: Seghir Nadir <nadir.seghir@gmail.com> Date: Wed May 12 13:32:05 2021 +0100 Add cart data to filters (#4164) * add cart data to filters * add extensions back to footer filter commit c10fdf2 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 12 13:04:44 2021 +0100 Pin dependency lodash to 4.17.21 (#4193) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit f92aac5 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 12 13:04:13 2021 +0100 Update dependency chalk to v4.1.1 (#4194) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 27cff51 Author: Mike Jolley <mike.jolley@me.com> Date: Wed May 12 13:02:26 2021 +0100 Should be using value rather than name (#4187) commit 560972a Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Tue May 11 13:57:02 2021 +0100 Add checkout filter for coupon names (#4166) * Make extensions optional, not all filters will need to pass this through For example the CartCouponSchema has no option for extensibility (and I don't think it's needed at any rate) so extensions will always be an empty object. Rather than explicitly specifying this when running the filter, we can let it default to an empty object. * Add filter for coupon code commit 556ceb4 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Tue May 11 11:45:02 2021 +0100 Check if variation data is iterable before formatting (#4182) commit 4279db8 Author: Darren Ethier <darren@roughsmootheng.in> Date: Mon May 10 11:21:01 2021 -0400 update package-lock (version change mostly) commit f71b24a Author: Darren Ethier <darren@roughsmootheng.in> Date: Mon May 10 11:16:58 2021 -0400 update version string to dev version commit 7f9c1b2 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon May 10 11:14:05 2021 -0400 Release: 5.1.0 (#4185) * Empty commit for release pull request * Add changelog * update testing notes * Bumping version strings to new version. Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Darren Ethier <darren@roughsmootheng.in> commit 80c2735 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon May 10 14:38:04 2021 +0200 Lock file maintenance (#4184) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 90074cf Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Mon May 10 10:03:30 2021 +0100 Convert shipping components to typescript (#4135) * Add type defs for customer Taken from https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/194ecccf780afe16843a894bb2e988509a0746df/assets/js/type-defs/customer.ts * Convert ShippingCalculatorAddress to TypeScript * Convert ShippingCalculator to TypeScript * Convert ShippingLocation to TypeScript * Allow packageId to be a number or string in useSelectShippingRate(s) * Convert ShippingRatesControl to TypeScript * Convert ShippingOptionsStep to TypeScript * Allow package_id to be a string or number This is because of Subscriptions using strings for package IDs * Change to use CartShippingRateItemShippingRate instead of Rate * Add extra props to PackageProps type * Make ShippingAddress have the correct type * Use CartShippingRateItemShippingRate instead of Rate * Remove Rate type * Set return types to JSX.Element * Change type of props.renderOption in ShippingRatesControl * Remove customer type defs and relocate aliases to default-address-fields * Add EnteredAddress type * Import EnteredAddress from new location * Remove unnecessary eslint ignore * Remove unused variable * Remove confusing use of word Item in Shipping types * Remove confusing use of word Item in Shipping types commit 3f1be39 Author: Albert Juhé Lluveras <contact@albertjuhe.com> Date: Mon May 10 10:00:14 2021 +0200 Feature gate PaymentApi (#4176) * Feature gate PaymentApi * Improve payment method missing dependencies error message so it's clear it only affects blocks * Add PaymentApi feature flags to list of feature flags in docs commit ed7eded Author: Darren Ethier <darren@roughsmootheng.in> Date: Fri May 7 16:39:28 2021 -0400 Improvements to `emitEventWithAbort`. (#4158) * modify emitEventWithAbort to change return value `emitEventWithAbort` now returns an array of responses up to the first response that triggered an error or fail response instead of aborting on success responses too. * update add to cart form context provider * update checkout state context provider * update payment method data context provider * update tests and fix thrown error handling. commit 2be9a4e Author: Raluca Stan <raluca.stan@automattic.com> Date: Fri May 7 15:50:55 2021 +0200 Add lodash as a devDependency (#4179) commit 69b3679 Author: Seghir Nadir <nadir.seghir@gmail.com> Date: Wed May 5 12:59:30 2021 +0100 Don't clear email and phone fields when using separate billing address. (#4162) * preseve-billing-data * pluck empty email and phone * add issue number commit 2140147 Author: Raluca Stan <raluca.stan@automattic.com> Date: Wed May 5 13:52:27 2021 +0200 Fix/cart backend test (#4153) * Fix backend cart e2e test * Adjust test structure * Fix e2e checkout backend test. Make sure the confirmation window is closed commit f8d9b90 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 5 10:08:45 2021 +0000 Update dependency @stripe/stripe-js to v1.14.0 (#4170) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 2391a40 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Wed May 5 10:41:48 2021 +0100 Add documentation for filters (#4167) * Rename the argument in the CheckoutFilterFunction type This only exists as an extra descriptive hint to anyone using this type, the value `label` was never used by anything so it does not need to be changed anywhere else. * Create Available Filters document * Add available filters to the extensibility README * Update docs/extensibility/available-filters.md to fix typographical error Co-authored-by: Mike Jolley <mike.jolley@me.com> Co-authored-by: Mike Jolley <mike.jolley@me.com> commit f4af89b Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 5 08:10:24 2021 +0000 Update dependency @woocommerce/e2e-utils to v0.1.4 (#4172) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 6c9e786 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 5 03:31:52 2021 +0000 Update dependency @types/react to v16.14.6 (#4171) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 3ba4d9e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 5 02:23:13 2021 +0000 Update babel monorepo (#4169) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 35f71df Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue May 4 14:07:05 2021 +0100 Lock file maintenance (#4163) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 4c65211 Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Apr 28 14:09:28 2021 +0000 Coped package-lock.json from trunk commit 703cb65 Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Apr 28 14:00:32 2021 +0000 Reverted package-lock.json ( downgraded node version to 12 ) commit 41dfd79 Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Apr 28 11:12:45 2021 +0000 Pre pull request clean up code commit 75fc62e Author: grogou <eriktadevosyan07@gmail.com> Date: Tue Apr 27 13:03:24 2021 +0000 Added Stock Status filter commit e7bd0e6 Author: grogou <eriktadevosyan07@gmail.com> Date: Fri Aug 20 16:53:56 2021 +0400 Escape statuses for sql query Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> commit 29c8493 Author: grogou <eriktadevosyan07@gmail.com> Date: Fri Aug 20 16:53:18 2021 +0400 Allow custom stock statuses Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> commit 63ecd04 Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 28 06:22:04 2021 +0000 Bring back removed css commit 27e0233 Author: grogou <eriktadevosyan07@gmail.com> Date: Tue Jul 27 23:35:15 2021 +0400 Update assets/js/blocks/stock-filter/block.js Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> commit 136c32d Author: groguo <eriktadevosyan07@gmail.com> Date: Thu Jul 15 06:50:06 2021 +0000 Fixed preview part for stock and attribute filters commit ef89751 Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Jul 14 20:15:05 2021 +0400 Update index.js commit a63dbce Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:43:06 2021 +0000 Review suggestion changes commit 6b0f5d2 Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:40:52 2021 +0000 Linter fix commit 791b38b Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:37:41 2021 +0000 Removed hideOutOfStock from AllProducts and realized hide out of stock functionality from SQL query commit 1a7a002 Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:21:51 2021 +0000 Created new component for Filters elements labels commit d9b7fae Author: aaron <aaron.yor@gmail.com> Date: Wed Jun 2 11:57:06 2021 +0400 Fix label includ path commit 5311584 Merge: 92a0da3 413a4e0 Author: aaron <aaron.yor@gmail.com> Date: Wed Jun 2 11:52:48 2021 +0400 Merge remote-tracking branch 'core/trunk' into add/stock-filter # Conflicts: # package-lock.json commit d8e6dab Merge: 42beb9b 4343b96 Author: grogou <eriktadevosyan07@gmail.com> Date: Fri Apr 30 12:28:09 2021 +0400 Merge pull request #1 from woocommerce/trunk Fork update commit 92a0da3 Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Apr 28 14:09:28 2021 +0000 Coped package-lock.json from trunk commit ae0d12b Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Apr 28 14:00:32 2021 +0000 Reverted package-lock.json ( downgraded node version to 12 ) commit 5e0c7f9 Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Apr 28 11:12:45 2021 +0000 Pre pull request clean up code commit 105b3f7 Author: grogou <eriktadevosyan07@gmail.com> Date: Tue Apr 27 13:03:24 2021 +0000 Added Stock Status filter
opr
added a commit
that referenced
this pull request
Aug 20, 2021
commit 4a14c226b739f3d88f99647206627ff351ef01ad Merge: 8cc7acd 4fccfd8 Author: Thomas Roberts <thomas.roberts@automattic.com> Date: Fri Aug 20 16:06:19 2021 +0100 Merge branch 'add/stock-filter' of git://github.com/NovemBit/woocommerce-gutenberg-products-block-fork into NovemBit-add/stock-filter commit 4fccfd8 Merge: 8012b2b e7bd0e6 Author: groguo <eriktadevosyan07@gmail.com> Date: Fri Aug 20 13:17:42 2021 +0000 Merge from trunk commit 8012b2b Author: grogou <eriktadevosyan07@gmail.com> Date: Fri Aug 20 16:53:56 2021 +0400 Escape statuses for sql query Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> commit 304348a Author: grogou <eriktadevosyan07@gmail.com> Date: Fri Aug 20 16:53:18 2021 +0400 Allow custom stock statuses Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> commit b2f01e4 Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 28 06:22:04 2021 +0000 Bring back removed css commit caafffd Author: grogou <eriktadevosyan07@gmail.com> Date: Tue Jul 27 23:35:15 2021 +0400 Update assets/js/blocks/stock-filter/block.js Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> commit ae381de Author: groguo <eriktadevosyan07@gmail.com> Date: Thu Jul 15 06:50:06 2021 +0000 Fixed preview part for stock and attribute filters commit 7df5fea Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Jul 14 20:15:05 2021 +0400 Update index.js commit af0294c Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:43:06 2021 +0000 Review suggestion changes commit 16da253 Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:40:52 2021 +0000 Linter fix commit 594125a Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:37:41 2021 +0000 Removed hideOutOfStock from AllProducts and realized hide out of stock functionality from SQL query commit 94a54e3 Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:21:51 2021 +0000 Created new component for Filters elements labels commit e3d7fb2 Author: aaron <aaron.yor@gmail.com> Date: Wed Jun 2 11:57:06 2021 +0400 Fix label includ path commit c9e3d02 Author: Seghir Nadir <nadir.seghir@gmail.com> Date: Tue Jun 1 09:46:02 2021 +0100 remove usage of mustBeString (#4294) commit b892339 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon May 31 16:07:59 2021 +0100 Lock file maintenance (#4290) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 6de68e4 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Thu May 27 12:57:49 2021 +0100 Check if product can be added to cart before adding ajax class to button (#4265) commit a1ccaf4 Author: Thomas Roberts <thomas.roberts@automattic.com> Date: Wed May 26 16:10:43 2021 +0100 Update version for next release commit 24f882f Author: Thomas Roberts <thomas.roberts@automattic.com> Date: Wed May 26 15:42:21 2021 +0100 Bumping version strings to new version. commit e1fd082 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Wed May 26 15:31:37 2021 +0100 Update link to testing zip commit 35521e5 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Wed May 26 14:04:42 2021 +0100 Fix display of itemised taxes (#4279) * Add price to itemised tax rates & hide Total when itemised taxes are on * Update snapshots for taxes in sidebar commit 7f3a1e6 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 26 08:52:31 2021 +0000 Update dependency downshift to v6.1.3 (#4272) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 593ef2b Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 26 05:04:55 2021 +0000 Update dependency @types/react to v16.14.8 (#4270) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 21f16d6 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 26 03:47:54 2021 +0000 Update dependency @woocommerce/e2e-utils to v0.1.5 (#4271) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 444256e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 26 02:30:17 2021 +0000 Update dependency @types/lodash to v4.14.170 (#4269) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 5f9df57 Author: Thomas Roberts <thomas.roberts@automattic.com> Date: Tue May 25 15:31:03 2021 +0100 Create 5.2.0 testing notes commit 45abda6 Author: Thomas Roberts <thomas.roberts@automattic.com> Date: Tue May 25 14:52:37 2021 +0100 Update package.json npm ci was not working correctly this will fix it. commit c3daa6c Author: Thomas Roberts <thomas.roberts@automattic.com> Date: Tue May 25 14:26:32 2021 +0100 Update changelog and WC tested up to commit 6128309 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Thu May 20 17:56:56 2021 +0100 Revert "Move `TextInput` to checkout package and allow it to be used for input type=number (#4238)" This reverts commit 15c1779. commit 193267b Author: Mike Jolley <mike.jolley@me.com> Date: Tue May 25 12:49:13 2021 +0100 Add key to each `CartTotalItem` (#4240) * Move type defs * Move type guards * Fix imports * Extract prepareTotalItems to TS file * usePaymentMethodInterface as TS file * Fix TS props * Fix currency type defs * Add return type to usePaymentMethodInterface * Add key prop to CartTotalItem * Fixed up js tests * Move SymbolPosition into type-defs package Co-authored-by: Thomas Roberts <thomas.roberts@automattic.com> commit c15e512 Author: Seghir Nadir <nadir.seghir@gmail.com> Date: Tue May 25 10:46:28 2021 +0100 Fix duplicate plugins by using wp.components global in the editor. (#4211) * fix duplicate slotProvider * load file on demand * add comment and load components in blocks as well * add todo block commit e2cf0ba Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Tue May 25 08:43:46 2021 +0100 Hide "including X in taxes" when the amount of tax is 0 (#4262) * Hide "including x in taxes" if tax amount is 0 * Add jest types to tsconfig * Move SHOW_TAXES into component body This is to make the code more testable and allows us to change values. There's no significant performance impact because of this change. * Add tests and snapshots for TotalsFooterItem commit 9b44c88 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon May 24 18:14:37 2021 +0100 Update dependency @octokit/graphql to v4.6.2 (#4230) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 4973132 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon May 24 16:40:05 2021 +0100 Lock file maintenance (#4253) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit b7eabf5 Author: Michael P. Pfeiffer <frontdevde@users.noreply.github.com> Date: Fri May 21 09:53:46 2021 +0200 Block Widgets: hide legacy widgets with a feature-complete block equivalent (#4237) * Block Widgets: hide legacy widgets with block equivalent * Unhide Products and Products by Rating widgets commit 47556b9 Author: Michael P. Pfeiffer <frontdevde@users.noreply.github.com> Date: Fri May 21 09:52:27 2021 +0200 Block Widgets: hide All Products and Filter blocks in the Customizer (#4225) commit 208b212 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Thu May 20 17:56:56 2021 +0100 Move `TextInput` to checkout package and allow it to be used for input type=number (#4238) * Move text-input to checkout package * Pass validation props directly to ValidatedTextInput * Import label relatively instead of from package * Pass validation functions to ValidatedTextInput This is so it doesn't need to get them from useValidationContext. * Add InputProps to ValidatedTextInput This will be used to control additional props on the input element of TextInput * Spread inputProps onto <input> element of TextInput * Export TextInput from @woocommerce/blocks-checkout * Add @woocommerce/blocks-checkout package to tsconfig * Allow styling to be applied to number inputs and when value is 0 * Make style order consistent * Remove inputProps to rely on rest in TextInput * Add specific prop for the inputErrorComponent * Only disallow active state if value is 0 AND type is number * Change all uses of ValidatedTextInput to also pass inputErrorComponent * Revert "Change all uses of ValidatedTextInput to also pass inputErrorComponent" This reverts commit ec734b9. * Revert "Remove inputProps to rely on rest in TextInput" This reverts commit 1fc64cc. * Revert "Revert "Change all uses of ValidatedTextInput to also pass inputErrorComponent"" This reverts commit 110e360. * Revert "Revert "Remove inputProps to rely on rest in TextInput"" This reverts commit aeb0352. * Don't pass errorMessage to ValidatedTextInput commit 55f5bfd Author: Mike Jolley <mike.jolley@me.com> Date: Thu May 20 15:07:12 2021 +0100 Create LICENSE (#4235) commit 0b10f75 Author: Albert Juhé Lluveras <contact@albertjuhe.com> Date: Thu May 20 10:58:59 2021 +0200 Update @woocommerce/components (#4100) * Add isCompact prop to components using SearchListControl * Update @woocommerce/components to 6.1.2 * Remove legacy CSS code * Add some CSS rules to override conflicting editor styles * Replace showCount prop with has-count class name * Create ExpandableSearchListItem component * Refactor ProductControl so it uses ExpandableSearchListItem * Update @woocommerce/components to 6.2.0 * Fix @woocommerce/components builds breaking * Fix a11y of expandable item list children * Set categories to an empty array by default * Render compact control in Attribute filter sidebar * Add countLabel to ProductAttributeTermControl * Fix ProductTagControl selected items * Use sentence case for countLabel * Fix wrong margins in block editor * Fix checkbox alignment * Update package-lock.json * Fix withCategories test * Fix JS error in Filter Products by Attribute block * Make input ids unique commit 587be17 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Wed May 19 10:55:15 2021 +0100 Convert TextInput and ValidatedTextInput to TypeScript (#4226) * Change index file from base/context to .ts This is to stop TS complaining when importing things from here. * Convert ValidatedTextInput to TypeScript * Convert TextInput to TypeScript * Ensure Label accepts correct HTML Attributes Props * Remove PropTypes from TextInput and ValidatedTextInput No longer needed because of TypeScript * Use correct error id to show validation message * Use HTMLElement instead of a specific element type for LabelProps * Update assets/js/base/components/text-input/validated-text-input.tsx Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> * Update assets/js/base/components/text-input/validated-text-input.tsx * Use correct formatting in ValidatedTextInput Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> commit 731c75e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 19 07:36:46 2021 +0000 Update dependency @testing-library/react-hooks to v5.1.3 (#4233) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit ef6ad88 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 19 04:36:44 2021 +0000 Update dependency @types/lodash to v4.14.169 (#4234) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 096463e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 19 03:46:21 2021 +0000 Update dependency @testing-library/react to v11.2.7 (#4232) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 8722839 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 19 02:48:45 2021 +0000 Update dependency @stripe/react-stripe-js to v1.4.1 (#4231) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 2f7e8ed Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 19 01:32:34 2021 +0000 Pin dependency @types/wordpress__deprecated to 2.4.2 (#4229) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 72e851a Author: Raluca Stan <raluca.stan@automattic.com> Date: Tue May 18 15:09:30 2021 +0200 Fix e2e checkout tests and adjust jest setup (#4216) * Fix checkout test - make tests independent & test also for empty cart case - make sure the Order summary is expanded with a better selector * Remove unnecessary localStorage operations from tests * Go to cart page before removing an item from cart * Remove logging observing before tests This removes unnecessary console.log interception. A big part of the logic was done for Puppeteer 1.6.1, but since 3.0.0 message.text() returns string. We allow console.error messages to surface in our tests. Although they don't cause the test to fail it might be a good addition for debugging purposes. commit 7b7119c Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue May 18 11:27:27 2021 +0100 Lock file maintenance (#4212) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 5f84e7d Author: Mike Jolley <mike.jolley@me.com> Date: Tue May 18 10:37:31 2021 +0100 Convert checkout state context provider to Typescript (#4200) * git move to ts files * Type the checkout state provider * Restore for loop for error handling * Types not needed * Consolodate response handling * Unused import * Fix defaults for onCheckoutAfterProcessingWithSuccess etc * Type useEmitResponse and remove isObject checks * useEmitResponse as const * Check that redirectUrl is string * Define actions as const * data.redirectUrl should be truthy * Add redirectURL todo item as followup * remove null fallback commit fccc72b Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Tue May 18 09:10:31 2021 +0100 Move Button and Label components to `@woocommerce/blocks-checkout` package (#4222) * Move Button to checkout package * Move Label to Components Package commit 0b91fbe Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Mon May 17 15:00:57 2021 +0100 Update design of cart and checkout sidebars (#4180) * Update cart/coupon/shipping design * Add order summary heading * Move and style discounts on checkout sidebar * Add rate to tax lines * Ensure the option to display taxes itemised is available to Cart block * Output individual tax items below the total & add styles for this * Add success notice under coupon input on successful coupon addition * Add border to bottom of Totals footer * Show success message when adding coupon * Add padding to cart item rows * Add preview data to cart for when taxes are enabled * Add rate to cart response type * Add showRateAfterTaxName attribute to Cart block * Add control to cart block to show rate percentage after rate name * Add rate % in cart totals only if option is toggled on * Pass showRateAfterTaxName attribute down to TotalsTaxes * Add showRateAfterTaxName to Checkout block * Add control to block editor for showRateAfterTaxName on Checkout * Pass showRateAfterTaxName down to TotalsTaxes in Checkout * Change label for showing tax rates in cart and checkout blocks * Add test to ensure Taxes section shows in Cart block * Add tests for cart sidebar and rate percentages * Remove order summary title from checkout sidebar * Check if taxes are enabled before rendering the option to show rate %s * Add ShippingVia component to show the selected rate in sidebar * Remove value from individual tax rates * Remove bold from Shipping via label * Remove coupon added successfully message * Ensure panel headings that are h2s are the same colour as others * Clean up eslint warnings * Show rate %s by default * Update snapshots following design changes Co-authored-by: Mike Jolley <mike.jolley@me.com> commit 0464883 Author: Albert Juhé Lluveras <contact@albertjuhe.com> Date: Sun May 16 20:00:06 2021 +0200 Don't default to fallback in getSetting if value is falsy (#4202) commit f95f12d Author: Mike Jolley <mike.jolley@me.com> Date: Sun May 16 18:59:32 2021 +0100 Fix es lint warnings (#4206) * Un-used PropTypes import * Avoid global and use ownerDocument * receiveCart return type * ignoreRestSiblings when destructuring for @typescript-eslint/no-unused-vars * Replace lodash find * Use global rather than window * Remove lodash map * move rule to overrides commit db589e7 Author: Raluca Stan <raluca.stan@automattic.com> Date: Sun May 16 19:41:34 2021 +0200 Fix cart and checkout frontend e2e tests (#4199) * Wip: fix e2e fe tests * Test that navigation ends * Fix waitForNavigation * comment out failing php test * click the dom element * Ensure navigation happens by waiting for it. Test page title. * remove skip and update docs * Revert "comment out failing php test" This reverts commit 7c40e8c. * Fix USD from merge conflict * Add missing check for page title * Try page.waitForFunction for text search * test to see checkout page title is correct * test checkout page url on CI * unde jest config change * Fix assertion for checkout page * remove extra localStorage item remove call Co-authored-by: Mike Jolley <mike.jolley@me.com> Co-authored-by: Nadir Seghir <nadir.seghir@gmail.com> commit b9b66f9 Author: Mike Jolley <mike.jolley@me.com> Date: Thu May 13 11:49:39 2021 +0100 Set order status to pending when no payment is needed (#4186) commit 8ed63f7 Author: Mike Jolley <mike.jolley@me.com> Date: Thu May 13 11:21:21 2021 +0100 Remove the need for the `canMakePayment` callback in the editor context (#4188) * Force can pay true in editor context * Update docs commit 90499cb Author: Mike Jolley <mike.jolley@me.com> Date: Thu May 13 11:20:37 2021 +0100 Sync customer data during checkout with draft orders. (#4197) * Update store when email changes * Add pluckEmail helper and convert to TS * improve guard * sync draft order with customer data commit a813c93 Author: Albert Juhé Lluveras <contact@albertjuhe.com> Date: Thu May 13 12:14:15 2021 +0200 Set default store currency to USD in tests (#4203) commit b140893 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu May 13 10:16:04 2021 +0200 Update dependency config to v3.3.6 (#4195) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit d68bb11 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu May 13 10:15:35 2021 +0200 Update dependency cssnano to v4.1.11 (#4196) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit beadbab Author: Seghir Nadir <nadir.seghir@gmail.com> Date: Wed May 12 13:32:05 2021 +0100 Add cart data to filters (#4164) * add cart data to filters * add extensions back to footer filter commit c10fdf2 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 12 13:04:44 2021 +0100 Pin dependency lodash to 4.17.21 (#4193) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit f92aac5 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 12 13:04:13 2021 +0100 Update dependency chalk to v4.1.1 (#4194) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 27cff51 Author: Mike Jolley <mike.jolley@me.com> Date: Wed May 12 13:02:26 2021 +0100 Should be using value rather than name (#4187) commit 560972a Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Tue May 11 13:57:02 2021 +0100 Add checkout filter for coupon names (#4166) * Make extensions optional, not all filters will need to pass this through For example the CartCouponSchema has no option for extensibility (and I don't think it's needed at any rate) so extensions will always be an empty object. Rather than explicitly specifying this when running the filter, we can let it default to an empty object. * Add filter for coupon code commit 556ceb4 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Tue May 11 11:45:02 2021 +0100 Check if variation data is iterable before formatting (#4182) commit 4279db8 Author: Darren Ethier <darren@roughsmootheng.in> Date: Mon May 10 11:21:01 2021 -0400 update package-lock (version change mostly) commit f71b24a Author: Darren Ethier <darren@roughsmootheng.in> Date: Mon May 10 11:16:58 2021 -0400 update version string to dev version commit 7f9c1b2 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon May 10 11:14:05 2021 -0400 Release: 5.1.0 (#4185) * Empty commit for release pull request * Add changelog * update testing notes * Bumping version strings to new version. Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Darren Ethier <darren@roughsmootheng.in> commit 80c2735 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon May 10 14:38:04 2021 +0200 Lock file maintenance (#4184) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 90074cf Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Mon May 10 10:03:30 2021 +0100 Convert shipping components to typescript (#4135) * Add type defs for customer Taken from https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/194ecccf780afe16843a894bb2e988509a0746df/assets/js/type-defs/customer.ts * Convert ShippingCalculatorAddress to TypeScript * Convert ShippingCalculator to TypeScript * Convert ShippingLocation to TypeScript * Allow packageId to be a number or string in useSelectShippingRate(s) * Convert ShippingRatesControl to TypeScript * Convert ShippingOptionsStep to TypeScript * Allow package_id to be a string or number This is because of Subscriptions using strings for package IDs * Change to use CartShippingRateItemShippingRate instead of Rate * Add extra props to PackageProps type * Make ShippingAddress have the correct type * Use CartShippingRateItemShippingRate instead of Rate * Remove Rate type * Set return types to JSX.Element * Change type of props.renderOption in ShippingRatesControl * Remove customer type defs and relocate aliases to default-address-fields * Add EnteredAddress type * Import EnteredAddress from new location * Remove unnecessary eslint ignore * Remove unused variable * Remove confusing use of word Item in Shipping types * Remove confusing use of word Item in Shipping types commit 3f1be39 Author: Albert Juhé Lluveras <contact@albertjuhe.com> Date: Mon May 10 10:00:14 2021 +0200 Feature gate PaymentApi (#4176) * Feature gate PaymentApi * Improve payment method missing dependencies error message so it's clear it only affects blocks * Add PaymentApi feature flags to list of feature flags in docs commit ed7eded Author: Darren Ethier <darren@roughsmootheng.in> Date: Fri May 7 16:39:28 2021 -0400 Improvements to `emitEventWithAbort`. (#4158) * modify emitEventWithAbort to change return value `emitEventWithAbort` now returns an array of responses up to the first response that triggered an error or fail response instead of aborting on success responses too. * update add to cart form context provider * update checkout state context provider * update payment method data context provider * update tests and fix thrown error handling. commit 2be9a4e Author: Raluca Stan <raluca.stan@automattic.com> Date: Fri May 7 15:50:55 2021 +0200 Add lodash as a devDependency (#4179) commit 69b3679 Author: Seghir Nadir <nadir.seghir@gmail.com> Date: Wed May 5 12:59:30 2021 +0100 Don't clear email and phone fields when using separate billing address. (#4162) * preseve-billing-data * pluck empty email and phone * add issue number commit 2140147 Author: Raluca Stan <raluca.stan@automattic.com> Date: Wed May 5 13:52:27 2021 +0200 Fix/cart backend test (#4153) * Fix backend cart e2e test * Adjust test structure * Fix e2e checkout backend test. Make sure the confirmation window is closed commit f8d9b90 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 5 10:08:45 2021 +0000 Update dependency @stripe/stripe-js to v1.14.0 (#4170) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 2391a40 Author: Thomas Roberts <5656702+opr@users.noreply.github.com> Date: Wed May 5 10:41:48 2021 +0100 Add documentation for filters (#4167) * Rename the argument in the CheckoutFilterFunction type This only exists as an extra descriptive hint to anyone using this type, the value `label` was never used by anything so it does not need to be changed anywhere else. * Create Available Filters document * Add available filters to the extensibility README * Update docs/extensibility/available-filters.md to fix typographical error Co-authored-by: Mike Jolley <mike.jolley@me.com> Co-authored-by: Mike Jolley <mike.jolley@me.com> commit f4af89b Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 5 08:10:24 2021 +0000 Update dependency @woocommerce/e2e-utils to v0.1.4 (#4172) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 6c9e786 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 5 03:31:52 2021 +0000 Update dependency @types/react to v16.14.6 (#4171) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 3ba4d9e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 5 02:23:13 2021 +0000 Update babel monorepo (#4169) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 35f71df Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue May 4 14:07:05 2021 +0100 Lock file maintenance (#4163) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 4c65211 Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Apr 28 14:09:28 2021 +0000 Coped package-lock.json from trunk commit 703cb65 Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Apr 28 14:00:32 2021 +0000 Reverted package-lock.json ( downgraded node version to 12 ) commit 41dfd79 Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Apr 28 11:12:45 2021 +0000 Pre pull request clean up code commit 75fc62e Author: grogou <eriktadevosyan07@gmail.com> Date: Tue Apr 27 13:03:24 2021 +0000 Added Stock Status filter commit e7bd0e6 Author: grogou <eriktadevosyan07@gmail.com> Date: Fri Aug 20 16:53:56 2021 +0400 Escape statuses for sql query Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> commit 29c8493 Author: grogou <eriktadevosyan07@gmail.com> Date: Fri Aug 20 16:53:18 2021 +0400 Allow custom stock statuses Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> commit 63ecd04 Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 28 06:22:04 2021 +0000 Bring back removed css commit 27e0233 Author: grogou <eriktadevosyan07@gmail.com> Date: Tue Jul 27 23:35:15 2021 +0400 Update assets/js/blocks/stock-filter/block.js Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> commit 136c32d Author: groguo <eriktadevosyan07@gmail.com> Date: Thu Jul 15 06:50:06 2021 +0000 Fixed preview part for stock and attribute filters commit ef89751 Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Jul 14 20:15:05 2021 +0400 Update index.js commit a63dbce Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:43:06 2021 +0000 Review suggestion changes commit 6b0f5d2 Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:40:52 2021 +0000 Linter fix commit 791b38b Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:37:41 2021 +0000 Removed hideOutOfStock from AllProducts and realized hide out of stock functionality from SQL query commit 1a7a002 Author: groguo <eriktadevosyan07@gmail.com> Date: Wed Jul 14 15:21:51 2021 +0000 Created new component for Filters elements labels commit d9b7fae Author: aaron <aaron.yor@gmail.com> Date: Wed Jun 2 11:57:06 2021 +0400 Fix label includ path commit 5311584 Merge: 92a0da3 413a4e0 Author: aaron <aaron.yor@gmail.com> Date: Wed Jun 2 11:52:48 2021 +0400 Merge remote-tracking branch 'core/trunk' into add/stock-filter # Conflicts: # package-lock.json commit d8e6dab Merge: 42beb9b 4343b96 Author: grogou <eriktadevosyan07@gmail.com> Date: Fri Apr 30 12:28:09 2021 +0400 Merge pull request #1 from woocommerce/trunk Fork update commit 92a0da3 Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Apr 28 14:09:28 2021 +0000 Coped package-lock.json from trunk commit ae0d12b Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Apr 28 14:00:32 2021 +0000 Reverted package-lock.json ( downgraded node version to 12 ) commit 5e0c7f9 Author: grogou <eriktadevosyan07@gmail.com> Date: Wed Apr 28 11:12:45 2021 +0000 Pre pull request clean up code commit 105b3f7 Author: grogou <eriktadevosyan07@gmail.com> Date: Tue Apr 27 13:03:24 2021 +0000 Added Stock Status filter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3603.
Fixes #4192.
Fixes #1243.
Fixes #1684.
This PR:
@woocommerce/componentsto version 6.2.0. That required making some changes here and there. They are explained in Tasks to do when updating@woocommerce/components#3603.ExpandableSearchListItemcomponent. There were several controls having a similar logic to make search list items expandable and it could be extracted to its own component. In the future, this could be uplifted to@woocommerce/components.Accessibility
Screenshots
How to test the changes in this Pull Request:
The controls modified in this PR are used in many blocks, so the steps below should be repeated for all of them.
Affected blocks:
Changelog