This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Correct textdomain from 'woo-gutenberg-product-blocks' to 'woo-gutenberg-products-blocks' #5020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
status: needs review
type: bug
rubikuserbot
requested review from
a team and
opr
and removed request for
a team
nielslange
requested review from
a team and
ralucaStan
and removed request for
opr and
a team
|
Size Change: -20 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
This was referenced Oct 28, 2021
opr
suggested changes
Oct 28, 2021
There was a problem hiding this comment.
Hi @nielslange looks like you've kept the s on blocks, however, it should read woo-gutenberg-products-block.
Could you also add more robust testing instructions for this PR since the current ones don't actually show the issue being fixed. Something like:
- Add the terms and conditions block to your Checkout block.
- Change your site language to Spanish and go to the Checkout block.
- Verify the text in the terms and conditions block is translated.
|
I also recommend changing the changelog entry to something like Fix missing translations in the Checkout block that were using an incorrect textdomain. This provides more details and is user-friendly |
Good catch, @opr!
Absolutely. Due to my incorrect fix, I could not see the change initially. That's why I haven't pointed out the testing instructions that you mentioned. I'll correct the testing instructions directly. |
Great suggestion, @ralucaStan. I've updated the changelog message accordingly. You could now review this PR. |
|
@nielslange on the block in the editor I see the translated string, but not on the front-end.
Any ideas why not? |
@opr I didn't notice that initially. I just looked up this problem and saw that both the editor and the frontend are fetching the translation from the constants.js file. The translations for the editor and the frontend are coming from this part: When debugging these parts, I do see the translated version in the editor, but the untranslated version in the frontend. However, the i18n functionality is enqueued in the frontend. I'll investigate what is causing this problem. |
nielslange
force-pushed
the
fix/5005-correct-textdomain
branch
from
c924d1b
to
dae696c
Compare
senadir
approved these changes
Nov 8, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
…erg-products-blocks' (woocommerce#5020) * Correct text domain
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
…erg-products-blocks' (woocommerce#5020) * Correct text domain
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #5005
Note
Some strings were using the textdomain
woo-gutenberg-product-blocksinstead ofwoo-gutenberg-products-blocks(note the missingsfor products). Even though these strings have been translated, due to the incorrect textdomain they aren't visible in the plugin.Testing instructions
trunk.'woo-gutenberg-product-blocks'.'woo-gutenberg-product-blocks'again.Additional notes
Issue #5005 is not entierly solved by this PR, but require a follow up PR to lazy load some missing translation files on the frontend.
Changelog