Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Products block Orderby options #67

Merged
merged 4 commits into from
Mar 19, 2018
Merged

Products block Orderby options #67

merged 4 commits into from
Mar 19, 2018

Conversation

claudiulodro
Copy link
Contributor

Closes #55

screen shot 2018-03-15 at 11 07 28 am

Disclaimer: The WC API doesn't support ordering by sales, rating, and random and doesn't have filters for modifying it from the feature plugin to support them. We will have to add these features in API v3. Until then the Gutenberg preview won't accurately reflect the orderby setting sometimes, but the frontend will accurately reflect the orderby setting.

Copy link
Member

@jameskoster jameskoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add price asc/desc as order options?

I think we can lose the random order.

All seems to be working well otherwise!

@warrendholmes
Copy link
Member

We will have to add these features in API v3.

@claudiulodro Does that mean we need to log a new issue on the repo? I had a look around and couldn't find it anywhere - but that's all quite new to me.

@claudiulodro
Copy link
Contributor Author

@warrendholmes I've opened an issue at the repo. I don't believe the missing orderby options in the API should affect user testing.

I'll have @jameskoster's requested changes today.

@claudiulodro
Copy link
Contributor Author

claudiulodro commented Mar 16, 2018

EDITED: I've added support for price ordering and removed support for random ordering. Price ordering isn't supported in the API, so I've updated this issue to also document we need support for that. Price ordering should work fine on the frontend, just not in the preview.

@claudiulodro
Copy link
Contributor Author

Also arranges the options alphabetically
@jameskoster
Copy link
Member

I updated the labels. Hopefully I did everything right :p

@claudiulodro
Copy link
Contributor Author

Looks good @jameskoster 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants