-
Notifications
You must be signed in to change notification settings - Fork 218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add price asc/desc as order options?
I think we can lose the random
order.
All seems to be working well otherwise!
@claudiulodro Does that mean we need to log a new issue on the repo? I had a look around and couldn't find it anywhere - but that's all quite new to me. |
@warrendholmes I've opened an issue at the repo. I don't believe the missing I'll have @jameskoster's requested changes today. |
EDITED: I've added support for price ordering and removed support for random ordering. Price ordering isn't supported in the API, so I've updated this issue to also document we need support for that. Price ordering should work fine on the frontend, just not in the preview. |
Also arranges the options alphabetically
I updated the labels. Hopefully I did everything right :p |
Looks good @jameskoster 👍 |
Closes #55
Disclaimer: The WC API doesn't support ordering by sales, rating, and random and doesn't have filters for modifying it from the feature plugin to support them. We will have to add these features in API v3. Until then the Gutenberg preview won't accurately reflect the orderby setting sometimes, but the frontend will accurately reflect the orderby setting.