Create a constants.js file with the NAMESPACE value

[Aljullu]

This PR creates a constants.js file as discussed here: #779 (comment).

How to test the changes in this Pull Request:

Creating a new post, adding the affected blocks and verifying they still fetch information should be enough to test.

Affected blocks:

• Featured Category
• Products by Attribute
• Products by Category
• Featured Product

Changelog

Internal: create a NAMESPACE constant and export it from assets/js/constant.js.

[mikejolley]

Isn't the namespace for the API actually wc/blocks? wc/blocks/products is an endpoint - and there is no guarantee we won't have other endpoints using the wc/blocks namespace in the future.

[nerrad]

Isn't the namespace for the API actually wc/blocks? wc/blocks/products is an endpoint - and there is no guarantee we won't have other endpoints using the wc/blocks namespace in the future.

This is a good point. With that in mind, I wonder if it'd be better to create an ENDPOINTS or ROUTES constant instead that is an object returning the endpoint strings. So you could have:

const ENDPOINTS = {
    root: 'wc/blocks',
    products: 'wc/blocks/products'
};

That retains flexibility for future additional endpoints?

Also, an education type question I have... are these endpoints part of a versioned api? If not, should they be? When I do a request to /wp-json on my local test site I see there are two routes related to blocks in the output namespaces; wc-blocks/v1 and wc/blocks. Is the wc-blocks/v1 namespace for blocks bundled with WooCommerce and wc/blocks reserved for the feature plugin?

[mikejolley]

@nerrad since it's a private API (now) we don't need to version--blocks is the only consumer on this API. The core version is being removed in 3.7.

[Aljullu]

Thanks for the reviews @mikejolley @nerrad. I replaced the NAMESPACE constant with the ENDPOINTS object @nerrad suggested.

This PR is ready for another look.

[nerrad]

I'm pre-approving because it's fine as is, but I do have a minor tweak to my original suggestion that I think is worth considering.

[nerrad]

Looks great! I know this is following my initial suggestion but I'm wondering if we should do something like this instead:

const NAMESPACE = '/wc/blocks';
export const ENDPOINTS = {
    root: NAMESPACE,
    products: `${ NAMESPACE }/products`,
};

• reduces chance of typo errors for the namespace on future endpoints added.
• easier swapping out of namespace (albeit search and replace is arguably just as easy).

[Aljullu]

Done in f727482.