Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login: check for isJetpackActive && isJetpackConnected #1177

Closed
3 tasks done
mindgraffiti opened this issue Aug 13, 2019 · 1 comment
Closed
3 tasks done

Login: check for isJetpackActive && isJetpackConnected #1177

mindgraffiti opened this issue Aug 13, 2019 · 1 comment
Labels
feature: login Related to any part of the log in or sign in flow, or authentication. status: on hold Currently not prioritized.

Comments

@mindgraffiti
Copy link
Contributor

Describe the bug
Ref. p99K0U-1yp-p2. In addition to our basic check hasJetpack, we need to be more stringent and check if the site has the Jetpack plugin activated and that it has successfully connected.

To Reproduce
Steps to reproduce the behavior:

  1. Have a site where Jetpack has been added, but isn't currently active. Alternatively: disable Jetpack on an active test site.
  2. Test the login flow. Even though Jetpack is not activated, it will allow logging in.
  3. Activate the Jetpack plugin, but disconnect it from the site. Go to Jetpack > Dashboard > Connections box, and click the "Manage site connection" link. Disconnect Jetpack by clicking the "Disconnect" button.
  4. The login flow allows the user to log in.

Screenshots

How to disconnect Jetpack, a visual guide:
disconnect-jetpack

Expected behavior
A user should only be allowed to log in when all three cases are true: hasJetpack && isJetpackConnected && isJetpackActive

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.

Mobile Environment
Please include:

  • Device: any
  • iOS version: any
  • WooCommerce iOS version: 2.5
@mindgraffiti mindgraffiti added feature: login Related to any part of the log in or sign in flow, or authentication. status: on hold Currently not prioritized. labels Aug 13, 2019
@mindgraffiti mindgraffiti added this to the Future milestone Aug 13, 2019
@mindgraffiti mindgraffiti added this to To do in Kanban Board (Deprecated) via automation Aug 13, 2019
@shiki shiki added this to Firehose in Continuous Improvements via automation Mar 12, 2020
@shiki shiki removed this from To do in Kanban Board (Deprecated) Mar 12, 2020
@shiki shiki removed this from the Future milestone Sep 11, 2020
@shiki
Copy link
Member

shiki commented Feb 25, 2021

Looks like we already do this here:

/// Encapsulates the rules that declare a WordPress site as having a valid
/// Jetpack installation
var hasValidJetpack: Bool {
return hasJetpack &&
isJetpackConnected &&
isJetpackActive
}

@shiki shiki closed this as completed Feb 25, 2021
Continuous Improvements automation moved this from Needs Triage to Done Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: login Related to any part of the log in or sign in flow, or authentication. status: on hold Currently not prioritized.
Projects
No open projects
Development

No branches or pull requests

2 participants