Dashboard: Improving the logic of detecting if a site has orders

[selanthiraiyan]

Quoting @hichamboushaba from an internal thread p1715164179010139-slack-C03L1NF1EA3

Problem

Currently, to detect if a site has orders or not following this (at least in Android):

1. We check how many orders we have in the DB, and if we have a non-zero count, we decide that the site has orders.
2. If we don’t have cached orders, we fetch the order’s count from the API.

This logic has a side effect, that for stores with orders, and before fetching the order list, we have a “flicker” in the dashboard caused by showing the “Share Store” card then hiding it after the API call (point 2), see the video for understanding what I mean.

RPReplay_Final1715164598.MP4

Solution

The new logic I suggest:

1. Start with cached order’s count, and if it’s != 0, then use it directly.
2. If there are no cached orders, check the cached value of order status options we get from the above endpoint, and if it’s not empty, then sum the total of all its values*.
3. If there are no cached values, then revert to fetching the order’s count from the API using the existing logic that we use now.

[dangermattic]

🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.